-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scavenge some previous updates to be Rails 7 friendly #990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i htink this was a zeitwerk and 6.1 to 7 change...
Closed
need to figure out why our custom list and item support failed on this upgrade ;-(. Maybe look at "positioning" gem.. |
epugh
added a commit
that referenced
this pull request
Jun 7, 2024
This gets Quepid looking more like a brand new 7.1 Rails app.
It's been a long long journey, however we are closing this in favour of #1033 |
epugh
added a commit
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made changes in #861 but put too many things into one PR. Now pick the best.
Motivation and Context
Rails 7.1 cause soon we want to be on 7.2!
How Has This Been Tested?
Screenshots or GIFs (if appropriate):
Types of changes
Checklist: