-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hlsl support #1082
Hlsl support #1082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the shading that you've simulated on the logo!
languages.yaml
Outdated
{2} |:|____|:||:| |:(___ |:| | ||
{2} |::::::::||:| \::::\ |:| | ||
{2} |:| |:||:|____ ____):||:|____ | ||
{2} |:| |:||::::::||:::::/ |::::::| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it looks a bit unusual with borders on the left, right, and top sides of the letters, but not the bottom. Have you considered adding a bottom border?
{2} _ _ _ _____ _
{2} |:| |:||:| /:____||:|
{2} |:|____|:||:| |:(___ |:|
{2} |::____::||:| \___:\ |:|
{2} |:| |:||:|____ ____):||:|____
{2} |_| |_||______||_____/ |______|
This is just a basic idea. It sacrifices some of the "filling," but you might be able to get creative with some other characters to get the best of both worlds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
languages.yaml
Outdated
Hlsl: | ||
type: programming | ||
ascii: | | ||
{0} $$ | ||
{0} $$$$$$$$ | ||
{0} $$$$$$$$$$$$$$$$$$ $$$ | ||
{0} $$$$$$$$$$$$$$$$$$$$$$$$$$$$ $$$$$ | ||
{0}${1}$$$$${0}$$$$$$$$$$$$$$$$$$$$$$$$$ $${1}$ | ||
{0}$$ $$$$$$$$$$$$$$$$$$$$$$$$$ $$$${1}$ | ||
{0}$$ $$$$$$$$$$$$$$$$$$$$$$$$$$$${1}$$$ | ||
{0}$$$$ $$$$$$$$$$$$$$$$$$$$$$$$$$${1}$$ | ||
{0} $$$$$$$$$$$$$$$$$$$$$$$$$$$$$$${1}$$$ | ||
{0} $$$$$$$$$$$$$$$$$$$$$$$$$${1}$$$$$ | ||
{0} $$$$$$$$$$$$$$$$$$$${1}$$$$$$$ | ||
{0} {1}$$$$$$$$$$$$${1}$$$$$$$$$$$ | ||
{0} {1}$$$$$$$$$$$$$$$$$$ | ||
{2} _ _ _ _____ _ | ||
{2} |:| |:||:| /:::::||:| | ||
{2} |:|____|:||:| |:(___ |:| | ||
{2} |::____::||:| \___:\ |:| | ||
{2} |:| |:||:|____ ____):||:|____ | ||
{2} |_| |_||______||_____/ |______| | ||
colors: | ||
ansi: | ||
- green | ||
- green | ||
- white | ||
hex: | ||
- "#00FF00" | ||
- "#006600" | ||
- "#FFFFFF" | ||
chip: "#AACE60" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @progDes007, the teapot looks great! 😄 Although I understand your reasoning behind using it as an emblem for this language, given the absence of an official logo for HLSL, it still feels somewhat arbitrary to me. Personally, I'm not particularly fond of the text below the teapot either, especially considering that we already use a similar design in the glsl logo. Considering HLSL is a Microsoft language, I'd like to offer a suggestion:
type: programming
ascii: |
{0}████████████████ {1}████████████████
{0}█████ ██ █████ {1}█████ █████████
{0}█████ ██ █████ {1}█████ █████████
{0}█████ █████ {1}█████ █████████
{0}█████ ██ █████ {1}█████ █████████
{0}█████ ██ █████ {1}█████ █████
{0}████████████████ {1}████████████████
{2}████████████████ {3}████████████████
{2}█████ █████ {3}█████ █████████
{2}█████ █████████ {3}█████ █████████
{2}█████ █████ {3}█████ █████████
{2}█████████ █████ {3}█████ █████████
{2}█████ █████ {3}█████ █████
{2}████████████████ {3}████████████████
colors:
ansi:
- red
- green
- blue
- yellow
hex:
- "#F65314"
- "#7CBB00"
- "#00A1F1"
- "#FFBB00"
chip: "#AACE60"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@o2sh Added the changes as you suggest
Pardon my "art". I hope legendary teapot will do :).