Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vercel): add section links #922

Merged
merged 5 commits into from
Jan 8, 2023

Conversation

ozwaldorf
Copy link
Contributor

@ozwaldorf ozwaldorf commented Jan 7, 2023

What

  • Adds section links to the vercel website
  • didn't see a npm script for running prettier, so I added one

Demo

Jumping via section link https://vercel-hw8vz6ref-o2sh.vercel.app/#Makefile

image

npm run format:

image

@vercel
Copy link

vercel bot commented Jan 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vercel 🔄 Building (Inspect) Jan 7, 2023 at 7:57PM (UTC)

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!
I'm tempted to attempt to auto-generate PR comments with links to the affected languages, but I think that would be a case of over-engineering 🤣

Anyway, some minor nitpicks about the CSS and HTML.

docs/vercel/public/sakura.css Outdated Show resolved Hide resolved
docs/vercel/src/lib/AsciiPreview.svelte Outdated Show resolved Hide resolved
@ozwaldorf
Copy link
Contributor Author

I also thought about autogenerating links too, it'd be a great feature for the future 😄

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one thought to consider, but I don't consider it as something that would prevent my approval. LGTM!

docs/vercel/src/lib/AsciiPreview.svelte Outdated Show resolved Hide resolved
@o2sh o2sh merged commit bef406a into o2sh:main Jan 8, 2023
@ozwaldorf ozwaldorf deleted the feat/add-section-links-vercel branch January 8, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants