Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade git-repository 0.30 to gix 0.36 #963

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Conversation

Byron
Copy link
Collaborator

@Byron Byron commented Feb 19, 2023

This upgrade is mainly to benefit from the new names of all git-* crates which now share the gix- prefix, with gix naturally being what was formerly git-repository.

Now there is no need anymore to rename crates in order to get the git namespace, instead we refer to gitoxide as gix from the get-go.

This upgrade is mainly to benefit from the new names of all `git-*`
crates which now share the `gix-` prefix, with `gix` naturally being
what was formerly `git-repository`.

Now there is no need anymore to rename crates in order to get the `git`
namespace, instead we refer to `gitoxide` as `gix` from the get-go.
Copy link
Owner

@o2sh o2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Byron 👍

BTW, do you have an ETA for the "git status/pending changes" support in gitoxide? Once we have this final piece, we'll be able to completely abandon git2 at last.

@Byron
Copy link
Collaborator Author

Byron commented Feb 19, 2023

Interestingly I thought exactly the same when doing this PR, just one more feature to go!

Unfortunately I have to follow priorities dictated by cargo for this half of the year which doesn't include this feature. Fortunately though, we don't have to wait that long as @pascalkuthe has already indicated interest in the task and I couldn't be more excited - helix is waiting for this feature too and I know we are going to get a high-performance, state-of-the-art implementation once he gives it a go 🎉.

@o2sh o2sh merged commit 7ec5240 into o2sh:main Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants