Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade gix to 0.36.1 to avoid breakage. #965

Merged
merged 1 commit into from
Feb 20, 2023
Merged

upgrade gix to 0.36.1 to avoid breakage. #965

merged 1 commit into from
Feb 20, 2023

Conversation

Byron
Copy link
Collaborator

@Byron Byron commented Feb 20, 2023

A recent release of bstr exposed incorrect usage of as_ref() causing compilation errors. Using v0.36.1 fixes the issue.

spenserblack
spenserblack requested changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CI is breaking when compiling git-glob at 0.5.1. Perhaps this needs to be bumped, too?

@Byron
upgrade gix to 0.36.1 to avoid breakage.
3bb51d8 
A recent release of `bstr` exposed incorrect usage of `as_ref()` causing
compilation errors.
Using v0.36.1 fixes the issue.
@Byron Byron requested a review from o2sh as a code owner February 20, 2023 16:29
@Byron
Copy link
Collaborator Author

Byron commented Feb 20, 2023

I forgot about git-testtools - I should be luckier this time.

spenserblack
spenserblack approved these changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@o2sh o2sh merged commit ce76a6d into main Feb 20, 2023
@Byron Byron deleted the upgrade-gitoxide branch February 20, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack approved these changes

@o2sh o2sh o2sh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Byron @spenserblack @o2sh