Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS #2097

Closed
2 tasks done
sptramer opened this issue Nov 16, 2022 · 1 comment
Closed
2 tasks done

Add CODEOWNERS #2097

sptramer opened this issue Nov 16, 2022 · 1 comment
Assignees
Labels
rfc-feature sig/docs-community Categorizes an issue or PR as relevant to SIG Docs-Community.

Comments

@sptramer
Copy link
Contributor

sptramer commented Nov 16, 2022

As part of the actions of accepting o3de/sig-docs-community#61 we need to create a CODEOWNERS file. This should follow the layout as described in the RFC, with the appropriate owners:

  • Reviewers/docs-reviewers - A new group created to split from the sig/docs-community reviewer/maintainer pool into different reviewers so that we can enforce the right controls on elements like blogs vs. documentation. Will start with membership identical to sig/docs-community-reviewers with opt-out.
  • Reviewers/community-reviewers - The other half of the split. Will start with membership identical to sig/docs-community-reviewers with opt-out.
  • Reviewers/web-reviewers - Reviewers for website code and infrastructure changes. This will start with a hand-selected pool of reviewers identified by prior commitments. Other membership will be opt-in.
  • Reviewers/*-sig/docs-tech-reviewers - New groups created as subgroups of each existing Reviewers/*-sig subgroup. These are the tech reviewer pools for each individual SIG. This may change based on the outcome of Message acceptance of RFC #61 sig-docs-community#75 if SIGs communicate that they are OK with the tech reviewer and docs reviewer pools being identical.
  • lf - The existing pool of Linux Foundation representatives on O3DE.

Tasks

  1. Infrastructure setup
  2. Create and merge CODEOWNERS
@chanmosq
Copy link
Contributor

Regarding how to populate the group for technical reviewers, RFC o3de/sig-docs-community#74 (and comments) proposes some possible solutions:

  1. Using the existing, all-encompassing Reviewers team
  2. Further organizing the CODEOWNERS file by assigning SIG reviewer teams to their respective areas in the docs.
  3. Populating a separate docs-tech-reviews team

This comment talks about using option 1 to start, and eventually transitioning to option 2.

There's not much strong support for option 3 -- seems like it would be more work that's not necessary, since each SIG is already maintaining their team of reviewers.

sptramer added a commit to aws-lumberyard-dev/o3de.org that referenced this issue Nov 29, 2022
…ATED o3de#2097]

Signed-off-by: Stephen Tramer <169061+sptramer@users.noreply.github.com>
sptramer added a commit to aws-lumberyard-dev/o3de.org that referenced this issue Nov 30, 2022
…F. [RELATED o3de#2097]

Signed-off-by: Stephen Tramer <169061+sptramer@users.noreply.github.com>
FiniteStateGit added a commit that referenced this issue Nov 30, 2022
Add CODEOWNERS for dev (more restrictive on main-only materials) [RELATED #2097]
chanmosq pushed a commit that referenced this issue Nov 30, 2022
…F. [RELATED #2097] (#2134)

Signed-off-by: Stephen Tramer <169061+sptramer@users.noreply.github.com>

Signed-off-by: Stephen Tramer <169061+sptramer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc-feature sig/docs-community Categorizes an issue or PR as relevant to SIG Docs-Community.
Projects
None yet
Development

No branches or pull requests

2 participants