Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffuse Probe Grid component docs #789

Merged
merged 5 commits into from
Aug 18, 2021
Merged

Conversation

chanmosq
Copy link
Contributor

@chanmosq chanmosq commented Aug 5, 2021

Updated the Diffuse Probe Grid component's reference page.

Signed-off-by: Chanelle Mosquera <chanmosq@amazon.com>
@chanmosq chanmosq self-assigned this Aug 5, 2021
Signed-off-by: Chanelle Mosquera <chanmosq@amazon.com>
@@ -5,18 +5,61 @@ description: "Open 3D Engine (O3DE) Diffuse Probe Grid component reference."
toc: true
---

{{< preview-new >}}
The **Diffuse Probe Grid** component creates a volume of light probes that provide diffuse global illumination (GI) within the specified area. Each probe in the volume uses real-time ray tracing to capture the *irradiance*, or surrounding diffuse light environment. Real-time ray tracing casts several hundred rays in different directions around each probe. The probe stores lighting information at each point of intersection between the ray and the mesh. Then, it creates an irradiance texture out of the ray traced data and applies the texture to each mesh.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stores lighting information at each point of intersection between the ray and the mesh

What mesh? Any mesh contained within the specified area? Might improve clarity if you can be more specific here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mesh may refer to the surrounding geometry? Or just the geometry within the volume.

@dmcdiarmid-ly Can you specify?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the meshes that the rays intersect with refer to all of the geometry in the level that are in the direction of the ray.

Hopefully this is more clear. I updated the sentence to:

At each point of intersection between the ray and the surrounding geometry, the probe stores lighting information.

Comment on lines 35 to 37
| **Y-Axis** | The amount of space between probes along the y-axis. The space must be within the Box Shape component's dimension along the y-axis. | `0.0` to the Box Shape component's `Dimensions`-`Y` property. | The lowest value from the Box Shape component's `Dimensions`-`XYZ` property. |
| **Z-Axis** | The amount of space between probes along the z-axis. The space must be within the Box Shape component's dimension along the z-axis. | `0.0` to the Box Shape component's `Dimensions`-`Z` property. | The lowest value from the Box Shape component's `Dimensions`-`XYZ` property. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default info doesn't seem right. I tried this and the default values for each axis were 2.0 meters, even though the lowest value of the box shape was 8.0 meters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing this, you're right the default value is 2.0 meters. I believe what I was observing may have been the probe spacing values updating when I update the mesh.

Signed-off-by: Chanelle Mosquera <chanmosq@amazon.com>
Signed-off-by: Chanelle Mosquera <chanmosq@amazon.com>
@micronAMZN micronAMZN merged commit ef57339 into o3de:main Aug 18, 2021
@chanmosq chanmosq deleted the diffuse-probe-grid branch December 14, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants