fix string constructible types failing conversion when not implicitly strings #17292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strings Signed-off-by: Alex Montgomery <alexmont@amazon.com>
alexmontAmazon
requested review from
AMZN-alexpete,
lemonade-dm,
Ulrick28,
AMZN-daimini and
gadams3
AMZN-alexpete
approved these changes
Dec 20, 2023
alexmontAmazon
added a commit
to alexmontAmazon/o3de
that referenced
this pull request
Jan 8, 2024
…o3de#17292) strings Signed-off-by: Alex Montgomery <alexmont@amazon.com>
alexmontAmazon
added a commit
that referenced
this pull request
Jan 8, 2024
* fix string constructible types failing conversion when not implicitly (#17292) strings Signed-off-by: Alex Montgomery <alexmont@amazon.com> * make sure cached attributes are removed before they are re-added (#17289) Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com>
alexmontAmazon
added a commit
that referenced
this pull request
Jan 9, 2024
* fix string constructible types failing conversion when not implicitly (#17292) strings Signed-off-by: Alex Montgomery <alexmont@amazon.com> * make sure cached attributes are removed before they are re-added (#17289) Signed-off-by: Alex Montgomery <alexmont@amazon.com> * Fix expansion state saving/restoring for PrefabOverrideLabelHandler (#17335) * quick fix for truncation warning * DCO Remediation Commit for Alex Montgomery <alexmont@amazon.com> I, Alex Montgomery <alexmont@amazon.com>, hereby add my Signed-off-by to this commit: e58664e Signed-off-by: Alex Montgomery <alexmont@amazon.com> * fix expansion state saving for PrefabOverrideLabelHandler Signed-off-by: Alex Montgomery <alexmont@amazon.com> * fix override label tests Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How was this PR tested?