Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all errors with default seeds #5489

Merged

Conversation

AMZN-stankowi
Copy link
Contributor

@AMZN-stankowi AMZN-stankowi commented Nov 10, 2021

Removed spot_default.dds from DefaultLevelSetup.slice because the file no longer exists.
Removed GeomCache.ent and GeomCache.lua because legacy entities are no longer functional.
Removed legacy special case job escalation for certain paths, because these paths mostly no longer exist or are empty.
Partially removed references to geometry caches from C++, geometry cache functionality was removed a while ago, and if it comes back it, it won't be the same.
Updated many simple asset references in uicanvas and slice files to .tif.streamingimage instead of .dds.
Removed the LmbrCentral default seed list, all files in it have been deleted.
Updated the missing image error in Sprite.cpp to include the asset ID, the failure I hit had a valid asset ID but not a path.
Fixed references to dds product assets to now reference tif.streamingimage product assets, the sub ID changed from 0 to 1,000.

@AMZN-stankowi AMZN-stankowi requested a review from a team November 10, 2021 15:31
@@ -699,7 +699,6 @@ namespace AssetBuilderSDK

// XML files may contain generic data (avoid this in new builders - use a custom extension!)
static const char* xmlExtensions = ".xml";
static const char* geomCacheExtensions = ".cax";
static const char* skeletonExtensions = ".chr";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still support CHR files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but I didn't want to get side tracked pulling out all of the unused code

@@ -60,7 +60,6 @@ struct IFileUtil
EFILE_TYPE_GEOMETRY,
EFILE_TYPE_TEXTURE,
EFILE_TYPE_SOUND,
EFILE_TYPE_GEOMCACHE,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this ECustomFileType enum is actually unused now (the SelectSingleFile methods are commented in the code), so maybe we could just remove the whole thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just didn't want to get sidetracked pulling out all the unused code. I have a few more critical tickets to get to right now.

Comment on lines -1368 to -1371
AzFramework::AssetSystemRequestBus::Broadcast(&AzFramework::AssetSystem::AssetSystemRequests::EscalateAssetBySearchTerm, "/texturemsg/");
AzFramework::AssetSystemRequestBus::Broadcast(&AzFramework::AssetSystem::AssetSystemRequests::EscalateAssetBySearchTerm, "engineassets/materials");
AzFramework::AssetSystemRequestBus::Broadcast(&AzFramework::AssetSystem::AssetSystemRequests::EscalateAssetBySearchTerm, "engineassets/geomcaches");
AzFramework::AssetSystemRequestBus::Broadcast(&AzFramework::AssetSystem::AssetSystemRequests::EscalateAssetBySearchTerm, "engineassets/objects");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we removing these assets in a different PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AMZN-stankowi AMZN-stankowi merged commit 6e70097 into o3de:stabilization/2110 Nov 11, 2021
@AMZN-stankowi AMZN-stankowi deleted the Helios_DefaultSeedFix branch November 11, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants