Add RFC for Allocator Availability #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for compassionate-kare-0aea30 ready! 🔨 Explore the source changes: 9b2eaca 🔍 Inspect the deploy log: https://app.netlify.com/sites/compassionate-kare-0aea30/deploys/6234f811a66a540008c8dc23 😎 Browse the preview: https://deploy-preview-31--compassionate-kare-0aea30.netlify.app |
burelc-amzn
force-pushed
the
allocatorAvailabilityRFC
branch
from
69bebc1
to
60f2740
Compare
Signed-off-by: Chris Burel <burelc@amazon.com>
burelc-amzn
force-pushed
the
allocatorAvailabilityRFC
branch
from
60f2740
to
9b2eaca
Compare
lemonade-dm
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
The RFC looks good to me.
I do wish we could keep AZStd out of the O3DEKernel library, but that shouldn't stop this proposal from going forward.
Plus this is something we can iterate on once it is in.
I think in future iterations we can expose something such as an O3DEKernelInterface INTERFACE target that only exposes the interfaces AZStd allocator adaptor interface.
|
pinging @o3de/sig-core reviewers |
jeremyong-az
approved these changes
Apr 14, 2022
spham-amzn
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View the document with markdown applied