Trigger OvfDataUpdater when detaching a storage domain #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a call to OvfDataUpdater#triggerNow right after detaching a storage domain in order to clean VMs/templates that were removed when the storage domain was detached from the vm_ovf_generations table immediately rather than in the next cycle we update the OVFs. In 78d21ee we fixed an issue that caused importing VMs/templates with old (stale) data. That fix could very well also fix the issue described in the below mentioned bug, however, it is safer to also ensure that the removed VMs/templates are also removed from the vm_ovf_generations table to stop having old/stale data in the database that should never be used. Bug-Url: https://bugzilla.redhat.com/1705338 Signed-off-by: Arik Hadas <ahadas@redhat.com>
mwperina
force-pushed
the
bug_1705338
branch
from
18b5dab
to
9bb5a2d
Compare
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a call to OvfDataUpdater#triggerNow right after detaching
a storage domain in order to clean VMs/templates that were removed when
the storage domain was detached from the vm_ovf_generations table
immediately rather than in the next cycle we update the OVFs.
In 78d21ee we fixed an issue that caused importing VMs/templates with
old (stale) data. That fix could very well also fix the issue described
in the below mentioned bug, however, it is safer to also ensure that the
removed VMs/templates are also removed from the vm_ovf_generations table
to stop having old/stale data in the database that should never be used.
Bug-Url: https://bugzilla.redhat.com/1705338
Signed-off-by: Arik Hadas ahadas@redhat.com