Replace userstorage #294
Merged
Replace userstorage #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesteve-rh
requested review from
nirs,
mz-pdm,
almusil and
tinez
as code owners
|
https://github.com/aesteve-rh/vdsm/actions/runs/2832404676 This is a test-run in my fork, using the containers uploaded to my |
nirs
reviewed
Aug 10, 2022
aesteve-rh
force-pushed
the
aesteve/replace-userstorage
branch
2 times, most recently
from
9c5301a
to
e4fbd3d
Compare
|
aesteve-rh#1 |
nirs
requested changes
Aug 27, 2022
aesteve-rh
force-pushed
the
aesteve/replace-userstorage
branch
from
e4fbd3d
to
8baff39
Compare
aesteve-rh
force-pushed
the
aesteve/replace-userstorage
branch
2 times, most recently
from
8b0c920
to
a4363f2
Compare
aesteve-rh
force-pushed
the
aesteve/replace-userstorage
branch
from
a4363f2
to
dc3d0cd
Compare
aesteve-rh
force-pushed
the
aesteve/replace-userstorage
branch
from
dc3d0cd
to
1f9e5b1
Compare
nirs
requested changes
Sep 12, 2022
aesteve-rh
force-pushed
the
aesteve/replace-userstorage
branch
6 times, most recently
from
f508089
to
460891f
Compare
aesteve-rh
force-pushed
the
aesteve/replace-userstorage
branch
from
460891f
to
9251401
Compare
aesteve-rh
force-pushed
the
aesteve/replace-userstorage
branch
from
9251401
to
606ad81
Compare
|
@nirs this should be ready to review (and hopefully merge) |
nirs
reviewed
Sep 23, 2022
Vdsm uses an outdated version of userstorage stored locally in the project. Change it so that it uses the installed package from PyPI. Change fixtures so that they use userstorage as a context manager so that it calls setup and teardown around every test consistently, and simplifies fixtures. Fixes: oVirt#151 Signed-off-by: Albert Esteve <aesteve@redhat.com>
Update storage README to reflect the new userstorage usage. Signed-off-by: Albert Esteve <aesteve@redhat.com>
aesteve-rh
force-pushed
the
aesteve/replace-userstorage
branch
from
606ad81
to
eda7201
Compare
nirs
approved these changes
Sep 23, 2022
nirs
added a commit
to nirs/userstorage
that referenced
this pull request
Oct 6, 2022
Vdsm is using userstorage since oVirt/vdsm#294
aesteve-rh
pushed a commit
to nirs/userstorage
that referenced
this pull request
Oct 6, 2022
Vdsm is using userstorage since oVirt/vdsm#294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vdsm uses an outdated version of userstorage
stored locally in the project.
Change it so that it uses the installed
package from PyPI.
Fixes: #151
Signed-off-by: Albert Esteve aesteve@redhat.com