Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bitmap info to getQemuImageInfo #394

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Add bitmap info to getQemuImageInfo #394

merged 1 commit into from
Jul 17, 2023

Conversation

dupondje
Copy link
Member

We add bitmap info the the getQemuImageInfo output so this can be used within ovirt-engine.

This might be a cleaner alternative to #393
As we just extend the existing call to also return the bitmap info.

@dupondje dupondje mentioned this pull request Jun 23, 2023
Closed
aesteve-rh
aesteve-rh reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@aesteve-rh aesteve-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could add a simple test for getQemuImageInfo with the new bitmaps information?

Something simple that creates an image, adds some bitmaps and different formats, and then checks that the info obtained is correct.

lib/vdsm/api/vdsm-api.yml Outdated Show resolved Hide resolved
lib/vdsm/storage/volume.py Outdated Show resolved Hide resolved
aesteve-rh
aesteve-rh requested changes Jun 30, 2023
View reviewed changes
Copy link
Member

@aesteve-rh aesteve-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for adding the checks on all those tests. Minor comment on a couple imports, but overall looks good to me.

I'll launch the pipelines to check how it looks :)

tests/storage/sdm_add_bitmap_test.py Show resolved Hide resolved
tests/storage/blocksd_test.py Show resolved Hide resolved
@dupondje dupondje force-pushed the add_bitmap_info branch 2 times, most recently from 12fa5aa to d41690d Compare June 30, 2023 14:16
@dupondje
Copy link
Member Author

All fixed! CI passes (except the unrelated failure on CI / test-storage-user (centos-9))

@aesteve-rh
Copy link
Member

All fixed! CI passes (except the unrelated failure on CI / test-storage-user (centos-9))

Thanks! Can you please amend the last commit and push to re-trigger the CI? The test that failed is the mailbox test that tends to fail if the runners are slow. Should be safe to retry.

@dupondje
Copy link
Member Author

Thanks! Can you please amend the last commit and push to re-trigger the CI? The test that failed is the mailbox test that tends to fail if the runners are slow. Should be safe to retry.

You should be able to retry the run in the actions tab on GitHub. I can push again later otherwise :)

@aesteve-rh
Copy link
Member

/ost

@aesteve-rh
Copy link
Member

/ost

1 similar comment
@aesteve-rh
Copy link
Member

/ost

dupondje added a commit to dupondje/ovirt-engine that referenced this pull request Jul 5, 2023
@dupondje
Add Qcow2BitmapInfo data to GetQemuImageInfo
dedb0a2 
Extend the GetQemuImageInfoVDSCommand command to also provide
information about the bitmaps.

This data will only be valid when the hypervisor has the
qemu_image_info_bitmaps capability.

The bitmap information can be used to validate the engine's bitmap data
with the qemu-img info.

VDSM PR: oVirt/vdsm#394

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
@dupondje dupondje mentioned this pull request Jul 5, 2023
Open
@dupondje @aesteve-rh
Add bitmap info to getQemuImageInfo
ea1a662 
We add bitmap info the the getQemuImageInfo output so this can be used
within ovirt-engine.

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
@aesteve-rh aesteve-rh merged commit 8cb3d98 into oVirt:master Jul 17, 2023
sandrobonazzola pushed a commit to dupondje/ovirt-engine that referenced this pull request Nov 28, 2023
@dupondje @sandrobonazzola
Add Qcow2BitmapInfo data to GetQemuImageInfo
170ac2e 
Extend the GetQemuImageInfoVDSCommand command to also provide
information about the bitmaps.

This data will only be valid when the hypervisor has the
qemu_image_info_bitmaps capability.

The bitmap information can be used to validate the engine's bitmap data
with the qemu-img info.

VDSM PR: oVirt/vdsm#394

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
sandrobonazzola pushed a commit to dupondje/ovirt-engine that referenced this pull request Jun 5, 2024
@dupondje @sandrobonazzola
Add Qcow2BitmapInfo data to GetQemuImageInfo
c08ada8 
Extend the GetQemuImageInfoVDSCommand command to also provide
information about the bitmaps.

This data will only be valid when the hypervisor has the
qemu_image_info_bitmaps capability.

The bitmap information can be used to validate the engine's bitmap data
with the qemu-img info.

VDSM PR: oVirt/vdsm#394

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
sandrobonazzola pushed a commit to dupondje/ovirt-engine that referenced this pull request Jun 10, 2024
@dupondje @sandrobonazzola
Add Qcow2BitmapInfo data to GetQemuImageInfo
16e2c78 
Extend the GetQemuImageInfoVDSCommand command to also provide
information about the bitmaps.

This data will only be valid when the hypervisor has the
qemu_image_info_bitmaps capability.

The bitmap information can be used to validate the engine's bitmap data
with the qemu-img info.

VDSM PR: oVirt/vdsm#394

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
sandrobonazzola pushed a commit to dupondje/ovirt-engine that referenced this pull request Oct 4, 2024
@dupondje @sandrobonazzola
Add Qcow2BitmapInfo data to GetQemuImageInfo
210f5fb 
Extend the GetQemuImageInfoVDSCommand command to also provide
information about the bitmaps.

This data will only be valid when the hypervisor has the
qemu_image_info_bitmaps capability.

The bitmap information can be used to validate the engine's bitmap data
with the qemu-img info.

VDSM PR: oVirt/vdsm#394

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
sandrobonazzola pushed a commit to dupondje/ovirt-engine that referenced this pull request Oct 4, 2024
@dupondje @sandrobonazzola
Add Qcow2BitmapInfo data to GetQemuImageInfo
2c818d8 
Extend the GetQemuImageInfoVDSCommand command to also provide
information about the bitmaps.

This data will only be valid when the hypervisor has the
qemu_image_info_bitmaps capability.

The bitmap information can be used to validate the engine's bitmap data
with the qemu-img info.

VDSM PR: oVirt/vdsm#394

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennyz bennyz bennyz left review comments

@aesteve-rh aesteve-rh aesteve-rh approved these changes

@tinez tinez Awaiting requested review from tinez tinez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dupondje @aesteve-rh @bennyz