Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist lein pids as hidden project files #83

Open
shaunlebron opened this issue Jan 29, 2015 · 3 comments
Open

Persist lein pids as hidden project files #83

shaunlebron opened this issue Jan 29, 2015 · 3 comments

Comments

@shaunlebron
Copy link
Collaborator

This will allow us to shutdown the processes when restarting Cuttle if it crashes or a user exits.

on load:

  • check if each project has a .cuttle-lein-pid
  • kill the process
  • remove pid file
@oakmac
Copy link
Owner

oakmac commented Jan 29, 2015

This is an excellent idea and should simplify the shutdown code.

On Thursday, January 29, 2015, Shaun LeBron notifications@github.com
wrote:

This will allow us to shutdown the processes when restarting Cuttle if it
crashes or a user exits.

on load:

  • check if each project has a .cuttle-lein-pid
  • kill the process
  • remove pid file


Reply to this email directly or view it on GitHub
#83.

@oakmac
Copy link
Owner

oakmac commented Jan 29, 2015

On second thought - it would be a really bad idea to persist pids after the application crashes. You run the risk of cancelling the pid of some other process when restarting Cuttle. But in general I like this idea while the application is running to simplify the shutdown code.

@shaunlebron
Copy link
Collaborator Author

We can inspect pids to be sure they are running lein with-profile +cuttle. And also it will keep us from have multiple Cuttle instances from trying to build the same project, though that's only really possible when running a release version alongside a dev version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants