Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1296] Update latest kernel check with OVERRIDABLE results #1021

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

pr-watson
Copy link
Contributor

@pr-watson pr-watson commented Dec 18, 2023

This PR updates is_loaded_kernel_latest.py ERROR results to OVERRIDABLE and the INVALID_KERNEL_PACKAGE ERROR to WARNING. There is also an update to a ValueError raised when there is an arch mismatch between kernel packages to inform the user it is likely due to incorrectly defined repositories on their system.

Jira Issues: RHELC-1296

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@pr-watson pr-watson added kind/feature New feature or request tests/all Run the full test suite. Equivalent to `/packit test`. labels Dec 18, 2023
@has-bot
Copy link
Member

has-bot commented Dec 18, 2023

/packit test


@oamg/conversions-qe please review results and provide ack.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e67ab3c) 94.32% compared to head (123b051) 94.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1021   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files          47       47           
  Lines        4549     4549           
  Branches      810      810           
=======================================
  Hits         4291     4291           
  Misses        182      182           
  Partials       76       76           
Flag Coverage Δ
centos-linux-7 89.50% <100.00%> (ø)
centos-linux-8 90.50% <100.00%> (ø)
centos-linux-9 90.56% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-watson pr-watson force-pushed the update-is-loaded-kernel-latest branch from ce209ce to 3b2987c Compare December 19, 2023 14:13
Copy link
Member

@r0x0d r0x0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Since this needs verification, I won't approve for now. Will wait for the tests.

@pr-watson
Copy link
Contributor Author

/packit test

@Venefilyn
Copy link
Member

Needs a refactor now

@pr-watson pr-watson force-pushed the update-is-loaded-kernel-latest branch from 3b2987c to 94b0171 Compare January 22, 2024 18:43
@pr-watson
Copy link
Contributor Author

Needs a refactor now

Just rebased

@pr-watson pr-watson force-pushed the update-is-loaded-kernel-latest branch from 94b0171 to 123b051 Compare January 22, 2024 19:10
@pr-watson
Copy link
Contributor Author

/packit retest-failed

Copy link
Member

@Venefilyn Venefilyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just needs to be tested in a VM

@pr-watson
Copy link
Contributor Author

PR has been tested in a VM

@Venefilyn Venefilyn merged commit 49550a3 into oamg:main Jan 25, 2024
53 of 61 checks passed
@Venefilyn Venefilyn mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request tests/all Run the full test suite. Equivalent to `/packit test`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants