-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHELC-1296] Update latest kernel check with OVERRIDABLE results #1021
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 47 47
Lines 4549 4549
Branches 810 810
=======================================
Hits 4291 4291
Misses 182 182
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ce209ce
to
3b2987c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Since this needs verification, I won't approve for now. Will wait for the tests.
/packit test |
Needs a refactor now |
3b2987c
to
94b0171
Compare
Just rebased |
94b0171
to
123b051
Compare
/packit retest-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just needs to be tested in a VM
PR has been tested in a VM |
This PR updates is_loaded_kernel_latest.py ERROR results to OVERRIDABLE and the INVALID_KERNEL_PACKAGE ERROR to WARNING. There is also an update to a ValueError raised when there is an arch mismatch between kernel packages to inform the user it is likely due to incorrectly defined repositories on their system.
Jira Issues: RHELC-1296
Checklist
[RHELC-]
is part of the PR titleRelease Pending
if relevant