[RHELC-1381] Port RestorablePackageSet to packages module #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
==========================================
+ Coverage 94.86% 94.92% +0.05%
==========================================
Files 48 49 +1
Lines 4539 4548 +9
Branches 808 808
==========================================
+ Hits 4306 4317 +11
+ Misses 158 156 -2
Partials 75 75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
r0x0d
force-pushed
the
port-restorable-package-set-backup-controller
branch
from
91e9d27
to
89ef688
Compare
r0x0d
added
kind/feature
pr-watson
approved these changes
Jan 30, 2024
|
/packit test --labels sanity |
r0x0d
force-pushed
the
port-restorable-package-set-backup-controller
branch
from
89ef688
to
5dcf04a
Compare
|
/packit test --labels sanity |
pr-watson
approved these changes
Feb 2, 2024
|
/packit retest-failed |
r0x0d
force-pushed
the
port-restorable-package-set-backup-controller
branch
from
5dcf04a
to
2a102a4
Compare
r0x0d
force-pushed
the
port-restorable-package-set-backup-controller
branch
from
2a102a4
to
5fc33d2
Compare
|
/packit test --labels sanity |
RestorablePackageSet is moved to be under the packages module inside the backup folder. This is one part of the refactoring of the backup controller to make it more organized and easier to work with. Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
r0x0d
force-pushed
the
port-restorable-package-set-backup-controller
branch
from
5fc33d2
to
c22ad7c
Compare
|
/packit test --labels sanity |
Venefilyn
approved these changes
Feb 6, 2024
|
Unit tests for the missing paths will be added as part of another PR. Since what is in main is already missing, we will work on this later. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RestorablePackageSet is moved to be under the packages module inside the backup folder. This is one part of the refactoring of the backup controller to make it more organized and easier to work with.
Jira Issues: RHELC-1381
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant