[RHELC-1376] Remove backup controller partition #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0x0d
added
the
tests/tier0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1096 +/- ##
==========================================
- Coverage 95.48% 95.40% -0.08%
==========================================
Files 51 51
Lines 4627 4612 -15
Branches 820 815 -5
==========================================
- Hits 4418 4400 -18
- Misses 134 137 +3
Partials 75 75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Looks good, everything about the partition removed. With testing, I'll wait till the blockers get merged. |
r0x0d
force-pushed
the
remove-partition-from-backup-controller
branch
from
e38cfe5
to
50649b4
Compare
pr-watson
reviewed
Feb 28, 2024
r0x0d
force-pushed
the
remove-partition-from-backup-controller
branch
from
50649b4
to
b3db692
Compare
Venefilyn
approved these changes
Mar 5, 2024
r0x0d
force-pushed
the
remove-partition-from-backup-controller
branch
from
b3db692
to
fee331a
Compare
|
/packit test --labels tier0 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround was introduced in #912 and #869, but it is no longer necessary as all legacy rollback items are now ported to be an instance tracked by the backup controller.
Jira Issues: RHELC-1376
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevantBlocked by