[RHELC-1432] Copy instead of move when restoring a file #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving a file back to its own directory is causing the file to lose the metadata and not letting the user enter in their system with SSH after the analysis is done. Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 51 51
Lines 4644 4645 +1
Branches 822 822
=======================================
+ Hits 4426 4427 +1
Misses 139 139
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bookwar
added
the
tests/tier0
|
/packit test --labels tier0 |
pholica
reviewed
Feb 29, 2024
| @@ -120,7 +120,8 @@ def restore(self, rollback=True): | |||
| return | |||
|
|
|||
| try: | |||
| shutil.move(self._backup_path, self.filepath) | |||
| shutil.copy2(self._backup_path, self.filepath) | |||
| os.remove(self._backup_path) | |||
There was a problem hiding this comment.
If there's an exception raised by the shutil.copy2 (for example the target directory doesn't exist), the os.remove is not called.
There was a problem hiding this comment.
Yes, but that's how we should have it. If something didn't go well with the copy we don't want to remove the backup
hosekadam
approved these changes
Mar 1, 2024
Merged
jochapma
pushed a commit
to jochapma/convert2rhel
that referenced
this pull request
Mar 11, 2024
Moving a file back to its own directory is causing the file to lose the metadata and not letting the user enter in their system with SSH after the analysis is done. Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving a file back to its own directory is causing the file to lose the metadata and not letting the user enter in their system with SSH after the analysis is done.
Jira Issues: RHELC-1432
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant