Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1426, RHELC-1428] Drop support for 8.6 EUS conversions #1132

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

r0x0d
Copy link
Member

@r0x0d r0x0d commented Mar 6, 2024

Deprecated the 8.6 EUS conversion, and removing the automatic detection of EUS systems.

From now on, users will be required to use --eus switch to identify their systems as EUS.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@r0x0d
Copy link
Member Author

r0x0d commented Mar 6, 2024

I will wait for @danmyway or @kokesak to adapt the integration test portion of this PR, as it is a lot of unknown stuff for me and I'm afraid of messing things up.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (588dd6d) to head (6c8b8de).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
- Coverage   95.36%   95.36%   -0.01%     
==========================================
  Files          53       53              
  Lines        4621     4619       -2     
  Branches      810      809       -1     
==========================================
- Hits         4407     4405       -2     
  Misses        137      137              
  Partials       77       77              
Flag Coverage Δ
centos-linux-7 90.45% <50.00%> (-0.01%) ⬇️
centos-linux-8 91.43% <100.00%> (-0.01%) ⬇️
centos-linux-9 91.48% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0x0d r0x0d added the kind/feature New feature or request label Mar 6, 2024
Copy link
Member

@Venefilyn Venefilyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this PR, I know it's a bit of work. But can we split the deprecation of 8.6 to a different PR?

@r0x0d
Copy link
Member Author

r0x0d commented Mar 20, 2024

For this PR, I know it's a bit of work. But can we split the deprecation of 8.6 to a different PR?

Sure, I can take care of that

@r0x0d r0x0d changed the title [RHELC-1426] Enable support for 8.10 EUS conversions [RHELC-1426] Drop support for 8.6 EUS conversions Apr 10, 2024
@r0x0d
Copy link
Member Author

r0x0d commented Apr 10, 2024

TODO: Rework on this at some point this/next week

Copy link
Member

@Venefilyn Venefilyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Venefilyn Venefilyn added tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. merge-after-tests-ok labels Apr 11, 2024
@has-bot
Copy link
Member

has-bot commented Apr 11, 2024

/packit test --labels sanity


Comment generated by an automation.

@Venefilyn
Copy link
Member

@r0x0d do we want to wait a bit before merging this just so we don't get integration tests failing for every PR while 8.6 integration tests still exist?

@r0x0d
Copy link
Member Author

r0x0d commented Apr 15, 2024

@r0x0d do we want to wait a bit before merging this just so we don't get integration tests failing for every PR while 8.6 integration tests still exist?

Let's check with @danmyway first, and if he says it is okay, then we can go ahead.

Deprecating 8.6 EUS conversions as we are supporting 8.8 now.
Update reference in the old alma and rocky repos to use 8.8 instead
@r0x0d
Copy link
Member Author

r0x0d commented Apr 18, 2024

/packit test --labels sanity

@danmyway
Copy link
Member

/packit test

1 similar comment
@danmyway
Copy link
Member

/packit test

@danmyway
Copy link
Member

/packit test

Copy link
Member

@kokesak kokesak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

* modify test files and metadata to address dropping 8.6

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
@danmyway
Copy link
Member

/packit test --labels tier0

@r0x0d r0x0d merged commit 2644404 into oamg:main Apr 23, 2024
33 checks passed
@r0x0d r0x0d deleted the add-810-eus-support branch April 23, 2024 11:55
@danmyway danmyway changed the title [RHELC-1426] Drop support for 8.6 EUS conversions [RHELC-1426, RHELC-1428] Drop support for 8.6 EUS conversions May 16, 2024
@hosekadam hosekadam mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants