-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHELC-1426, RHELC-1428] Drop support for 8.6 EUS conversions #1132
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1132 +/- ##
==========================================
- Coverage 95.36% 95.36% -0.01%
==========================================
Files 53 53
Lines 4621 4619 -2
Branches 810 809 -1
==========================================
- Hits 4407 4405 -2
Misses 137 137
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4d33d99
to
ec68afd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this PR, I know it's a bit of work. But can we split the deprecation of 8.6 to a different PR?
Sure, I can take care of that |
ec68afd
to
0b2a71f
Compare
TODO: Rework on this at some point this/next week |
0b2a71f
to
86e5f7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@r0x0d do we want to wait a bit before merging this just so we don't get integration tests failing for every PR while 8.6 integration tests still exist? |
Deprecating 8.6 EUS conversions as we are supporting 8.8 now.
Update reference in the old alma and rocky repos to use 8.8 instead
3e9313b
to
6aef24f
Compare
/packit test --labels sanity |
/packit test |
1 similar comment
/packit test |
6f39b5e
to
b487133
Compare
/packit test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* modify test files and metadata to address dropping 8.6 Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
b487133
to
6c8b8de
Compare
/packit test --labels tier0 |
Deprecated the 8.6 EUS conversion, and removing the automatic detection of EUS systems.
From now on, users will be required to use --eus switch to identify their systems as EUS.
Jira Issues:
Checklist
[RHELC-]
is part of the PR titleRelease Pending
if relevant