[RHELC-1425, RHELC-1429] Remove -v|--variant arg
#1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Venefilyn
added
kind/breaking
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1149 +/- ##
==========================================
- Coverage 95.42% 95.42% -0.01%
==========================================
Files 51 51
Lines 4593 4588 -5
Branches 810 809 -1
==========================================
- Hits 4383 4378 -5
Misses 134 134
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/packit test |
As we are going to do a major version change we want to remove all deprecated and unused client-facing things, such as the unsupported naming and deprecated arguments. This change has to do with removing `--variant` as it is no longer used and serves no purpose. Related RHELC-1425
Venefilyn
force-pushed
the
chore/remove-variant-option
branch
from
32e9af6
to
54258be
Compare
|
/packit test |
|
/packit build |
danmyway
changed the title
-v|--variant arg-v|--variant arg
Merged
hosekadam
changed the title
-v|--variant arg-v|--variant arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are going to do a major version change we want to remove all
deprecated and unused client-facing things, such as the unsupported
naming and deprecated arguments.
This change has to do with removing
--variantas it is no longer usedand serves no purpose.
Jira Issues:
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant