[RHELC-1347] Update report to include post conversion actions

[r0x0d]

The report had to be updated to include the post conversion results from
the actions, since we are extending the framework and migrating the
functions to become actions, we need to make a few modifications to
adapt the reporting to work with both pre and post conversion actions.

Jira Issues: RHELC-1347

Checklist

• PR has been tested manually in a VM (either author or reviewer)
• Jira issue has been made public if possible
• [RHELC-] is part of the PR title
• GitHub label has been added to help with Release notes
• PR title explains the change from the user's point of view
• Code and tests are documented properly
• The commits are squashed to as few commits as possible (without losing data)
• When merged: Jira issue has been updated to Release Pending if relevant

Depends on

• [RHELC-1342] Add post conversion stages for Action Framework #1144
• [RHELC-1328] Migrate post conversion transaction function #1152

[codecov]

Codecov Report

Attention: Patch coverage is 97.29730% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.38%. Comparing base (2644404) to head (7633a3a).

Files	Patch %	Lines
convert2rhel/main.py	95.45%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
+ Coverage   95.36%   95.38%   +0.01%     
==========================================
  Files          53       53              
  Lines        4619     4635      +16     
  Branches      809      810       +1     
==========================================
+ Hits         4405     4421      +16     
  Misses        137      137              
  Partials       77       77              

Flag	Coverage Δ
centos-linux-7	90.48% <97.29%> (+0.03%)	⬆️
centos-linux-8	91.46% <97.29%> (+0.02%)	⬆️
centos-linux-9	91.51% <94.59%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Venefilyn]

Didn't review unit tests yet

[has-bot]

/packit test --labels tier0

---

Comment generated by an automation.

Log | Bot Usage

[r0x0d]

/packit test --labels tier0

[Venefilyn]

Implementation seems pretty good to me, just wondering about the usage of deciding pre-conversion vs post-conversion report in the try-finally. I feel like it introduces technical debt for future refactoring

[r0x0d]

Implementation seems pretty good to me, just wondering about the usage of deciding pre-conversion vs post-conversion report in the try-finally. I feel like it introduces technical debt for future refactoring

@SpyTec, I agree, and by far, this doesn't even look like a solid implementation.

What do you think about something like this? (It's just a draft, so I just put whatever name I first thought of)

diff --git a/convert2rhel/main.py b/convert2rhel/main.py
index f59b738..f26e563 100644
--- a/convert2rhel/main.py
+++ b/convert2rhel/main.py
@@ -43,6 +43,18 @@ class ConversionPhase:
     POST_PONR_CHANGES = 4
 
 
+_REPORT_MAPPING = {
+    ConversionPhase.PRE_PONR_CHANGES: (
+        report.CONVERT2RHEL_PRE_CONVERSION_JSON_RESULTS,
+        report.CONVERT2RHEL_PRE_CONVERSION_TXT_RESULTS,
+    ),
+    ConversionPhase.POST_PONR_CHANGES: (
+        report.CONVERT2RHEL_POST_CONVERSION_JSON_RESULTS,
+        report.CONVERT2RHEL_POST_CONVERSION_TXT_RESULTS,
+    ),
+}
+
+
 def initialize_file_logging(log_name, log_dir):
     """
     Archive existing file logs and setup all logging handlers that require
@@ -182,16 +194,12 @@ def main_locked():
         # Write the assessment to a file as json data so that other tools can
         # parse and act upon it.
         results = _pick_conversion_results(process_phase, pre_conversion_results, post_conversion_results)
-        json_filepath = report.CONVERT2RHEL_PRE_CONVERSION_JSON_RESULTS
-        txt_filepath = report.CONVERT2RHEL_PRE_CONVERSION_TXT_RESULTS
 
-        if process_phase == ConversionPhase.POST_PONR_CHANGES:
-            json_filepath = report.CONVERT2RHEL_POST_CONVERSION_JSON_RESULTS
-            txt_filepath = report.CONVERT2RHEL_POST_CONVERSION_TXT_RESULTS
+        if results and process_phase in _REPORT_MAPPING:
+            json_report, txt_report = _REPORT_MAPPING[process_phase]
 
-        if results:
-            report.summary_as_json(results, json_filepath)
-            report.summary_as_txt(results, txt_filepath)
+            report.summary_as_json(results, json_report)
+            report.summary_as_txt(results, txt_report)
 
     return 0

It looks less bad or more bad?

[Venefilyn]

It looks less bad or more bad?

I think it definitely looks better. If you can change it to that for now that would be good, then we can merge. For _pick_conversion_results I still feel like that function has a bad smell but something we can take care of in the future if we ever get to an issue there that requires refactoring

[r0x0d]

/packit test --labels tier0