[RHELC-1465] Set consistent task prefix for pre-conversion #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1154 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 51 51
Lines 4605 4605
Branches 810 810
=======================================
Hits 4391 4391
Misses 137 137
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Venefilyn
reviewed
Mar 21, 2024
tests/integration/tier0/non-destructive/rollback-handling/test_rollback_handling.py
Show resolved
Hide resolved
r0x0d
force-pushed
the
normalize-task-header
branch
from
b972ce6
to
e75be4a
Compare
Venefilyn
approved these changes
Mar 25, 2024
|
/packit build |
Venefilyn
added
skip/changelog
Venefilyn
changed the title
Venefilyn
force-pushed
the
normalize-task-header
branch
from
e75be4a
to
08191b6
Compare
|
/packit test |
Some task headers for pre-conversion were using "Convert" instead of "Prepare". Since we are dealing with actions that are present before we start the conversion, all of those log tasks were changed to contain the word "Prepare" instead to not sound confusing to the user as what is happening.
r0x0d
force-pushed
the
normalize-task-header
branch
from
08191b6
to
6cea701
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some task headers for pre-conversion were using "Convert" instead of "Prepare". Since we are dealing with actions that are present before we start the conversion, all of those log tasks were changed to contain the word "Prepare" instead to not sound confusing to the user as what is happening.
Jira Issues: RHELC-1465
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant