Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHELC-1428, RHELC-1366, RHELC-1594, RHELC-1468] Include 8.10 in tests, introduce CentOS Stream #1244

Merged
merged 10 commits into from
Jun 18, 2024
Merged

[RHELC-1428, RHELC-1366, RHELC-1594, RHELC-1468] Include 8.10 in tests, introduce CentOS Stream #1244

merged 10 commits into from
Jun 18, 2024

Conversation

danmyway
Copy link
Member

@danmyway danmyway commented May 27, 2024 •
edited
Loading

  • create a new (for now) plan stream.fmf for CentOS Stream 8
  • include CentOS Stream in the pipeline
  • add 8.10 related adjustments to tests
  • change Alma and Rocky Linux image versions to the 8.10

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@danmyway danmyway added the kind/tests Improvement or enhancement of the tests label May 27, 2024
@danmyway danmyway mentioned this pull request May 27, 2024
Closed
8 tasks
@codecov Codecov
Copy link

codecov bot commented May 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.73%. Comparing base (9067a38) to head (b5a177b).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1244   +/-   ##
=======================================
  Coverage   95.73%   95.73%           
=======================================
  Files          55       55           
  Lines        4761     4761           
  Branches      838      838           
=======================================
  Hits         4558     4558           
  Misses        116      116           
  Partials       87       87
Flag Coverage Δ
centos-linux-7 90.92% <ø> (ø)
centos-linux-8 91.85% <ø> (ø)
centos-linux-9 91.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danmyway danmyway added the tests/skip This PR does not require integration tests to be run. label May 27, 2024
@has-bot
Copy link
Member

has-bot commented May 27, 2024

This PR does not require integration tests to be run.

Comment generated by an automation.

@danmyway
Copy link
Member Author

/packit test --labels stream

@danmyway
Copy link
Member Author

/packit test

@danmyway
Copy link
Member Author

/packit test --labels stream-8

@danmyway
Copy link
Member Author

/packit test --labels stream-8

@danmyway
Copy link
Member Author

/packit test --labels stream-8

1 similar comment
@danmyway
Copy link
Member Author

/packit test --labels stream-8

@danmyway
Copy link
Member Author

/packit test --labels stream-8

@danmyway
Copy link
Member Author

/packit test

@danmyway
Copy link
Member Author

/packit test

@danmyway danmyway requested a review from kokesak May 30, 2024 11:37
@danmyway danmyway marked this pull request as ready for review May 30, 2024 11:37
@danmyway
Copy link
Member Author

/packit test

@danmyway danmyway requested a review from kokesak May 31, 2024 09:02
kokesak
kokesak reviewed May 31, 2024
View reviewed changes
plans/tier0.fmf Outdated Show resolved Hide resolved
plans/tier1.fmf Outdated Show resolved Hide resolved
plans/stream.fmf Show resolved Hide resolved
kokesak
kokesak reviewed May 31, 2024
View reviewed changes
.packit.yaml Show resolved Hide resolved
@kokesak
Copy link
Member

kokesak commented May 31, 2024

/packit test

danmyway
danmyway commented May 31, 2024
View reviewed changes
plans/tier0.fmf Show resolved Hide resolved
plans/stream.fmf Show resolved Hide resolved
.packit.yaml Show resolved Hide resolved
@kokesak
Copy link
Member

kokesak commented Jun 3, 2024

/packit test --labels stream-8

@kokesak
Copy link
Member

kokesak commented Jun 3, 2024

It seems that the URLs in the CentOS-Stream image got outdated today. The mirror list is now depracated http://mirror.centos.org/centos/8-stream/. We have to use the vault url instead, otherwise the yum calls will not work. I'm going to talk to the TF folks about it

@kokesak
Copy link
Member

kokesak commented Jun 4, 2024 •
edited
Loading

It seems that the URLs in the CentOS-Stream image got outdated today. The mirror list is now depracated http://mirror.centos.org/centos/8-stream/. We have to use the vault url instead, otherwise the yum calls will not work. I'm going to talk to the TF folks about it

This needs to be merged and deployed - https://gitlab.com/testing-farm/infrastructure/-/merge_requests/610.
Until then the tests are going to be failing

@kokesak kokesak changed the title [RHELC-1428, RHELC-1366] Include 8.10 in tests, introduce CentOS Stream [RHELC-1428, RHELC-1366, RHELC-1594] Include 8.10 in tests, introduce CentOS Stream Jun 4, 2024
@kokesak
Copy link
Member

kokesak commented Jun 4, 2024

/packit test --labels sanity

@danmyway
Copy link
Member Author

danmyway commented Jun 10, 2024 •
edited
Loading

It seems that the URLs in the CentOS-Stream image got outdated today. The mirror list is now depracated http://mirror.centos.org/centos/8-stream/. We have to use the vault url instead, otherwise the yum calls will not work. I'm going to talk to the TF folks about it

This needs to be merged and deployed - https://gitlab.com/testing-farm/infrastructure/-/merge_requests/610. Until then the tests are going to be failing

Going with post-install-script update, that should help until infra picks up.

@danmyway
Copy link
Member Author

/packit test

danmyway and others added 10 commits June 18, 2024 10:11
@danmyway
Include 8.10 in tests, introduce CentOS Stream
439d0c3 
* create a new (for now) plan stream.fmf for CentOS Stream 8
* include CentOS Stream in the pipeline
* add 8.10 related adjustments to tests

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
@danmyway
Include satellite test, etc.
5716129 
Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
@danmyway
Modify the stream and tier0 plan
8aa5212 
* add couple of tests, modify the indentation, rename others to core

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
@danmyway
Do not use the hybrid_rocky_image on efi
f525a6d 
* use only on bios

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
@danmyway
Fix older kernel installation on Alma and Rocky
4472a96 
* we installed a kernel too old, so RHEL incompatible kmods got inserted
* install the kernel from less distant minor (8.8 - 8.6, 8.10 - 8.8)

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
@danmyway
Address review comments
7429ec9 
* remove resolve dependency test in the stream plan
  * the package we tried to install as a dependency issue causing pkg is
    breaking CentOS Stream altogether

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
@kokesak @danmyway
Fix stream-8-latest distro word in the plans
09879b6
@kokesak @danmyway
Change Alma and Rocky Linux images to 8.10
fc9d2d8
@danmyway
Update post-install-script on Stream
0ec498c 
* update the post install script to point the repositories to vault,
  since CentOS Stream 8 is EOL

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
@danmyway
Point CentOS 8 repo urls to vaul
b5a177b 
Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
kokesak
kokesak approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@kokesak kokesak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kokesak kokesak merged commit f1d3a93 into oamg:main Jun 18, 2024
18 checks passed
@kokesak kokesak mentioned this pull request Jun 18, 2024
Merged
8 tasks
@danmyway danmyway changed the title [RHELC-1428, RHELC-1366, RHELC-1594] Include 8.10 in tests, introduce CentOS Stream [RHELC-1428, RHELC-1366, RHELC-1594, RHELC-1468] Include 8.10 in tests, introduce CentOS Stream Jun 21, 2024
This was referenced Aug 21, 2024
Merged
Merged
@danmyway danmyway deleted the tests-8.10 branch September 3, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0x0d r0x0d r0x0d left review comments

@kokesak kokesak kokesak approved these changes

Assignees
No one assigned
Labels
kind/tests Improvement or enhancement of the tests tests/skip This PR does not require integration tests to be run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danmyway @has-bot @kokesak @r0x0d