Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix versioning of Sphinx in GH Actions #1262

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Venefilyn
Copy link
Member

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@Venefilyn Venefilyn requested a review from bookwar June 13, 2024 14:37
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (9c4e6c0) to head (9f95685).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1262   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          55       55           
  Lines        4756     4756           
  Branches      836      836           
=======================================
  Hits         4558     4558           
  Misses        112      112           
  Partials       86       86           
Flag Coverage Δ
centos-linux-7 91.02% <ø> (ø)
centos-linux-8 91.95% <ø> (ø)
centos-linux-9 92.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Venefilyn Venefilyn marked this pull request as ready for review June 19, 2024 13:14
@Venefilyn
Copy link
Member Author

Marking as ready for now @bookwar @r0x0d. I think we can fix the issues of not recognizing stuff in a different PR as it requires a bit more work. But this should at least make it a tiny bit better and allow us to open the HTML out locally a bit faster

@Venefilyn Venefilyn added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run. labels Jun 19, 2024
@has-bot
Copy link
Member

has-bot commented Jun 19, 2024

This PR does not require integration tests to be run.


Comment generated by an automation.

@r0x0d
Copy link
Member

r0x0d commented Jun 20, 2024

Just resolving the conflicts and I think we can merge, @Venefilyn.

@Venefilyn Venefilyn enabled auto-merge (rebase) June 20, 2024 14:07
@Venefilyn Venefilyn merged commit 3c8e4a3 into oamg:main Jun 20, 2024
15 of 18 checks passed
@Venefilyn Venefilyn deleted the chore/fix-sphinx-doc branch June 20, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants