chore: Remove forceful cleanup of all containers #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Venefilyn
added
skip/changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 55 55
Lines 4771 4771
Branches 840 840
=======================================
Hits 4573 4573
Misses 112 112
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
A while back it was introduced to cleanup the containers due to caching issue. This also cleans up your own containers and should not be ran locally whatsoever as it forcefully removes all containers. This is just a removal for now. It is better to have to run the command twice than have to deal with the aftermath of all your own containers suddenly being gone.
Venefilyn
force-pushed
the
chore/remove-forceful-container-removal
branch
from
a3d4fd2
to
dc14294
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back it was introduced to cleanup the containers due to caching
issue. This also cleans up your own containers and should not be ran
locally whatsoever as it forcefully removes all containers.
This is just a removal for now. It is better to have to run the command
twice than have to deal with the aftermath of all your own containers
suddenly being gone.
Introduced in #295
Jira Issues:
Checklist
[RHELC-]or[HMS-]is part of the PR titleRelease Pendingif relevant