Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1163] Update Skip results to have diagnosis and remediation fields #943

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

pr-watson
Copy link
Contributor

This PR updates the set result for each "SKIP" result to have an updated description as well as diagnosis and remediation fields.
Jira Issues: RHELC-1163

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@pr-watson pr-watson added the kind/feature New feature or request label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (594da2b) 93.92% compared to head (eb1ddbb) 93.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #943   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files          41       41           
  Lines        4147     4147           
  Branches      739      739           
=======================================
  Hits         3895     3895           
  Misses        179      179           
  Partials       73       73           
Flag Coverage Δ
centos-linux-7 89.29% <100.00%> (ø)
centos-linux-8 89.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
convert2rhel/actions/__init__.py 98.09% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0x0d r0x0d added the tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`. label Sep 28, 2023
@has-bot
Copy link
Member

has-bot commented Sep 28, 2023

/packit test --labels tier0


@oamg/conversions-qe please review results and provide ack.

@pr-watson
Copy link
Contributor Author

/packit test --labels tier0

@pr-watson pr-watson merged commit ef43eca into oamg:main Sep 29, 2023
30 of 43 checks passed
@bocekm bocekm mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants