Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1055] Change the default message of an empty report message field #945

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

hosekadam
Copy link
Member

@hosekadam hosekadam commented Sep 27, 2023

Based on conversation with Marek Hulan from Satellite in which he will be showing to the user the text form of the pre-conversion analysis report, we decided to change the default message from [No further information given] to N/A.

This is how a text report looked like before this change - report.txt - not that easy to read because of the many [No further information given] messages.

What do you think about this change, @mportman12 ?

Jira Issues: RHELC-1055

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f67fc2b) 93.92% compared to head (ad98300) 93.92%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #945   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files          41       41           
  Lines        4147     4147           
  Branches      739      739           
=======================================
  Hits         3895     3895           
  Misses        179      179           
  Partials       73       73           
Flag Coverage Δ
centos-linux-7 89.29% <100.00%> (ø)
centos-linux-8 89.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
convert2rhel/actions/__init__.py 98.09% <100.00%> (ø)
convert2rhel/actions/report.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bocekm bocekm added kind/feature New feature or request tests/skip This PR does not require integration tests to be run. labels Sep 27, 2023
@has-bot
Copy link
Member

has-bot commented Sep 27, 2023

This PR does not require integration tests to be run.


@oamg/conversions-qe please review results and provide ack.

Copy link
Member

@r0x0d r0x0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@mportman12 mportman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Venefilyn Venefilyn merged commit 5804336 into oamg:main Sep 28, 2023
17 of 47 checks passed
@bocekm bocekm changed the title [RHELC-1055] Change the default message in report [RHELC-1055] Change the default message of an empty report message field Oct 30, 2023
@bocekm bocekm mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request tests/skip This PR does not require integration tests to be run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants