[RHELC-1117] Fix backtrace in kernel signature verification #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old method we used was causing a backtrace during the fingerprint verification as it was consulting the yumdb and in return it was reporting metadata that was not relevant. This commit introduces an minimal refactor that changes the way we query for the package, so instead of relying in querying the rpmdb first, we use rpm directly to do the job. Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #952 +/- ##
==========================================
- Coverage 93.99% 93.99% -0.01%
==========================================
Files 44 44
Lines 4166 4164 -2
Branches 739 739
==========================================
- Hits 3916 3914 -2
Misses 177 177
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sometimes lsmod was failing because it couldn't be found in the system, and since the return or execution of this function is not needed by the test result, mocking it to null value is an easy fix. Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
pr-watson
approved these changes
Oct 10, 2023
r0x0d
added
bug
|
Did anyone verify to work this in a VM? |
I did while I was developing the solution, but not sure if someone else tested it either... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old method we used was causing a backtrace during the fingerprint verification as it was consulting the yumdb and in return it was reporting metadata that was not relevant.
This commit introduces an minimal refactor that changes the way we query for the package, so instead of relying in querying the rpmdb first, we use rpm directly to do the job.
Jira Issues: RHELC-1117
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant