[RHELC-1089] Add OVERRIDABLE result to package up to date analysis

[pr-watson]

This PR adds the "OVERRIDABLE" result in areas where the ask_to_continue() function was previously removed. The change allows for users to skip these checks by setting an environment variable.

Jira Issues: RHELC-1089

Checklist

• PR has been tested manually in a VM (either author or reviewer)
• Jira issue has been made public if possible
• [RHELC-] is part of the PR title
• GitHub label has been added to help with Release notes
• PR title explains the change from the user's point of view
• Code and tests are documented properly
• The commits are squashed to as few commits as possible (without losing data)
• When merged: Jira issue has been updated to Release Pending if relevant

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (8c77aa0) 93.78% compared to head (9243378) 93.66%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
- Coverage   93.78%   93.66%   -0.12%     
==========================================
  Files          47       47              
  Lines        4343     4358      +15     
  Branches      769      771       +2     
==========================================
+ Hits         4073     4082       +9     
- Misses        192      197       +5     
- Partials       78       79       +1     

Flag	Coverage Δ
centos-linux-7	88.60% <72.22%> (-0.10%)	⬇️
centos-linux-8	89.67% <72.22%> (-0.11%)	⬇️
centos-linux-9	89.74% <72.22%> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...vert2rhel/actions/system_checks/package_updates.py	88.23% <72.22%> (-11.77%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[has-bot]

/packit test --labels tier0

---

@oamg/conversions-qe please review results and provide ack.

Log | Bot Usage

[Venefilyn]

I wonder if CONVERT2RHEL_PACKAGE_UP_TO_DATE_CHECK_SKIP and CONVERT2RHEL_PACKAGE_NOT_UP_TO_DATE_CHECK_SKIP could be improved so they don't look alike

[pr-watson]

I wonder if CONVERT2RHEL_PACKAGE_UP_TO_DATE_CHECK_SKIP and CONVERT2RHEL_PACKAGE_NOT_UP_TO_DATE_CHECK_SKIP could be improved so they don't look alike

Do you mean like the naming of the keys?

[Venefilyn]

I wonder if CONVERT2RHEL_PACKAGE_UP_TO_DATE_CHECK_SKIP and CONVERT2RHEL_PACKAGE_NOT_UP_TO_DATE_CHECK_SKIP could be improved so they don't look alike

Do you mean like the naming of the keys?

Exactly

[pr-watson]

I wonder if CONVERT2RHEL_PACKAGE_UP_TO_DATE_CHECK_SKIP and CONVERT2RHEL_PACKAGE_NOT_UP_TO_DATE_CHECK_SKIP could be improved so they don't look alike

Do you mean like the naming of the keys?

Exactly

Let me brainstorm some new names

[pr-watson]

@SpyTec how about renaming CONVERT2RHEL_PACKAGE_NOT_UP_TO_DATE_CHECK_SKIP to CONVERT2RHEL_OUTDATED_PACKAGE_CHECK_SKIP and the SKIP id from SKIP_PACKAGE_NOT_UP_TO_DATE to SKIP_OUTDATED_PACKAGE_CHECK

[Venefilyn]

@SpyTec how about renaming CONVERT2RHEL_PACKAGE_NOT_UP_TO_DATE_CHECK_SKIP to CONVERT2RHEL_OUTDATED_PACKAGE_CHECK_SKIP and the SKIP id from SKIP_PACKAGE_NOT_UP_TO_DATE to SKIP_OUTDATED_PACKAGE_CHECK

I think that sounds better!

[Venefilyn]

Same here, don't display anywhere that the environment variables exist

[pr-watson]

Same here, don't display anywhere that the environment variables exist

I've added a mention to the environment variable inside the remediation of the overridable result