[RHELC-1378] Add remediation to overridable result in package updates action #989
Conversation
pr-watson
added
kind/feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #989 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 47 47
Lines 4552 4552
Branches 811 811
=======================================
Hits 4294 4294
Misses 182 182
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| remediation="If you wish to ignore this message, set the environment variable " | ||
| "'CONVERT2RHEL_OUTDATED_PACKAGE_CHECK_SKIP' to 1.", |
There was a problem hiding this comment.
Do we want to say something about disregarding/skipping/not performing the check instead of ignoring it? 🤔
There was a problem hiding this comment.
Using ignore is what we have across the other remediation fields for overriding a check, I wouldn't be opposed to changing it to something else for all of them though
There was a problem hiding this comment.
I'll make a jira for this change
There was a problem hiding this comment.
convert2rhel/unit_tests/actions/system_checks/package_updates_test.py
Outdated
Show resolved
Hide resolved
pr-watson
force-pushed
the
add-remediation
branch
from
cb46260
to
23c50d3
Compare
pr-watson
changed the title
|
/packit test |
This PR adds a remediation to the overrdiable result in the package_updates.py action. The remediation lets the user know they can set an environment variable to skip the OUT_OF_DATE_PACKAGES check within the action.
Jira Issues: RHELC-1378
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant