[RHELC-1173] Replace the word skip in report messages
#990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-watson
added
kind/feature
pr-watson
changed the title
pr-watson
force-pushed
the
rename-skip
branch
from
b160904
to
50b1582
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
=======================================
Coverage 94.35% 94.35%
=======================================
Files 47 47
Lines 4588 4588
Branches 819 819
=======================================
Hits 4329 4329
Misses 182 182
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Venefilyn
reviewed
Nov 24, 2023
Venefilyn
reviewed
Nov 24, 2023
convert2rhel/unit_tests/actions/pre_ponr_changes/special_cases_test.py
Outdated
Show resolved
Hide resolved
pr-watson
force-pushed
the
rename-skip
branch
from
04e398e
to
8796019
Compare
Venefilyn
reviewed
Jan 8, 2024
r0x0d
reviewed
Jan 23, 2024
|
Needs rebase |
pr-watson
force-pushed
the
rename-skip
branch
3 times, most recently
from
d3dcb44
to
e03bf69
Compare
Venefilyn
approved these changes
Jan 25, 2024
|
/packit test |
Venefilyn
changed the title
skip in report messages
|
Integration tests failing, likely some integration tests need to be updated. Not on VPN atm |
pr-watson
force-pushed
the
rename-skip
branch
from
b610245
to
a8e8280
Compare
|
Updated integration tests, thanks @SpyTec |
|
/packit test |
Venefilyn
requested changes
Jan 29, 2024
pr-watson
force-pushed
the
rename-skip
branch
from
a8e8280
to
c46394d
Compare
Good catch, thanks I just updated it |
|
/packit test |
Venefilyn
approved these changes
Jan 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of 'skip' and 'skipping' with 'Did not perform' in the preconversion analysis report messages so as to not create confusion with the skip status put in place for when we cannot run an action because another one failed.
Jira Issues: RHELC-1173
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant