scaninstalledtargetkernelversion: Detect kernel-core package on RHEL 8+

[matejmatuska]

On RHEL 8+ the kernel package was split into multiple packages including kernel-core. The kernel package is just a placeholder there and might not be installed.

The kernel-rt package was split similarly.

Let's scan for kernel-core and (kernel-rt-core on RHEL Real Time) instead which should always be present.

Fixes #1021

Jira ref.: OAMG-8383

[github-actions]

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

• review please to notify leapp developers of review request
• /packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

• /rerun to schedule basic regression tests using this pr build and leapp*master* as artifacts
• /rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
• /rerun-sst to schedule sst tests using this pr build and leapp*master* as artifacts
• /rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

[fernflower]

/rerun

[fernflower]

Codewise lgtm, let's see about regression tests.

[fernflower]

Just one thing - could you please add reference to the upstream issue? Something like Closes: #1021 ? #1021

[github-actions]

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5374423

[MichalHe]

Just correct the unit test kernel RHEL versions and the patch is good to go.

[github-actions]

Testing Farm request for RHEL-8.6-rhui/5374423 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-rhui/5374423 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-8.6.0-Nightly/5374423 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-8.7.0-Nightly/5374423 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[matejmatuska]

Tested also with real time kernel.
Booted on el8 with:

[root@localhost ~]# uname -r
4.18.0-425.10.1.rt7.220.el8_7.x86_64

After IPU to el9 the kernel is:

[root@localhost ~]# uname -r
5.14.0-70.30.1.rt21.102.el9_0.x86_64

And leapp-inspector shows that the produced message contains the expected version:

[root@localhost ~]# leapp-inspector messages | grep -A 7 installed_ta
Actor: scan_installed_target_kernel_version
Phase: RPMUpgrade
Type: InstalledTargetKernelVersion
Message_data:
{
    "version": "5.14.0-70.30.1.rt21.102.el9_0.x86_64"
}
----------------------------------------------------------------------

[github-actions]

Testing Farm request for RHEL-7.9-ZStream/5374423 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-ZStream/5374423 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[MichalHe]

I've tested the patch on 8>9 with non-rt kernel, and 7>8 with rt kernel, but no rhel8 rt kernel available, everything went OK. LGTM. I'll wait on the results on integration tests and merge it.

[MichalHe]

Most of the integration tests failed due to subscription-manager. Merging, as rhui e2e passed, and I have tested the patch myself.

[fernflower]

Wow, hold on with merge please, rhel8.6 /tests/nondestructive/oamg3903_fstab_options crash troubles me

Process Process-245:


Traceback (most recent call last):
  File "/usr/lib64/python3.6/multiprocessing/process.py", line 258, in _bootstrap
    self.run()
 File "/usr/lib64/python3.6/multiprocessing/process.py", line 93, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib/python3.6/site-packages/leapp/repository/actor_definition.py", line 74, in _do_run
    actor_instance.run(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/leapp/actors/__init__.py", line 289, in run
    self.process(*args)
  File "/etc/leapp/repos.d/system_upgrade/common/actors/xfsinfoscanner/actor.py", line 23, in process
    scan_xfs()
  File "/etc/leapp/repos.d/system_upgrade/common/actors/xfsinfoscanner/libraries/xfsinfoscanner.py", line 45, in scan_xfs
    mountpoints_ftype0 = list(filter(is_xfs_without_ftype, mountpoints))
  File "/etc/leapp/repos.d/system_upgrade/common/actors/xfsinfoscanner/libraries/xfsinfoscanner.py", line 24, in is_xfs_without_ftype
    for l in run(['/usr/sbin/xfs_info', '{}'.format(mp)], split=True)['stdout']:
  File "/usr/lib/python3.6/site-packages/leapp/libraries/stdlib/__init__.py", line 188, in run
    result=result
leapp.libraries.stdlib.CalledProcessError: Command ['/usr/sbin/xfs_info', '/foo'] failed with exit code 1.

=================================================================================================

Actor xfs_info_scanner unexpectedly terminated with exit code: 1 - Please check the above details

=================================================================================================�[0m
Debug output written to /var/log/leapp/leapp-preupgrade.log

Upd. Feels like an unrelated thing that deserves another bug report.

[fernflower]

Folks, there is a traceback in tests run, please don't merge this until investigated.

[MichalHe]

@fernflower yup, I've seen the xfs_info thing and was checking message dependencies whether there is a change of the PR influencing the xfs_scanner, but there should not be any chance of the test failures being caused by this PR

[fernflower]

Test failure is unrelated, sorry for the paranoid squirrel mode. Merging.