missinggpgkeys: Generate more reports in unusual situations instead of only logging

[Jakuje]

No description provided.

[github-actions]

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

• review please to notify leapp developers of review request
• /packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

• /rerun to schedule basic regression tests using this pr build and leapp*master* as artifacts
• /rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
• /rerun-sst to schedule sst tests using this pr build and leapp*master* as artifacts
• /rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

[leapp-bot]

This PR has been linked in issue tracker (OAMG-8403).

[pirat89]

Done a fast overview and it seems good. I will focus on this more later this week (fri?)

[pirat89]

@Jakuje Currently it's crashing as it is trying to get info about gpgkey even when gpgcheck is 0 and gpgkey is not specified:

2023-02-09 15:51:15.572 DEBUG    PID: 18267 leapp.workflow.TargetTransactionCheck.missing_gpg_keys_inhibitor: External command has started: ['gpg2', '--show-keys', '--with-colons', '/etc/leapp/repos.d/system_upgrade/common/files/rpm-gpg/9/RPM-GPG-KEY-redhat-release']
gpg: directory '/root/.gnupg' created
gpg: keybox '/root/.gnupg/pubring.kbx' crepub:-:4096:1:199E2F91FD431D51:1256212795:::-:::scSC::::::23::0:
fpr:::::::::567Eated
gpg: /root/.gnupg/trustdb.gpg: trustdb created
347AD0044ADE55BA8A5F199E2F91FD431D51:
uid:-::::1256212795::DC1CAEC7997B3575101BB0FCAAC6191792660D8F::Red Hat, Inc. (release key 2) <security@redhat.com>::::::::::0:
pub:-:4096:1:5054E4A45A6340B3:1646863006:::-:::scSC::::::23::0:
fpr:::::::::7E4624258C406535D56D6F135054E4A45A6340B3:
uid:-::::1646863006::DA7F68E3872D6E7BDCE05225E7EB5F3ACDD9699F::Red Hat, Inc. (auxiliary key 3) <security@redhat.com>::::::::::0:
2023-02-09 15:51:15.589 DEBUG    PID: 18267 leapp.workflow.TargetTransactionCheck.missing_gpg_keys_inhibitor: External command has finished: ['gpg2', '--show-keys', '--with-colons', '/etc/leapp/repos.d/system_upgrade/common/files/rpm-gpg/9/RPM-GPG-KEY-redhat-release']
Process Process-383:
Traceback (most recent call last):
  File "/usr/lib64/python3.6/multiprocessing/process.py", line 258, in _bootstrap
    self.run()
  File "/usr/lib64/python3.6/multiprocessing/process.py", line 93, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib/python3.6/site-packages/leapp/repository/actor_definition.py", line 74, in _do_run
    actor_instance.run(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/leapp/actors/__init__.py", line 289, in run
    self.process(*args)
  File "/etc/leapp/repos.d/system_upgrade/common/actors/missinggpgkeysinhibitor/actor.py", line 40, in process
    missinggpgkey.process()
  File "/usr/lib/python3.6/site-packages/leapp/utils/deprecation.py", line 42, in process_wrapper
    return target_item(*args, **kwargs)
  File "/etc/leapp/repos.d/system_upgrade/common/actors/missinggpgkeysinhibitor/libraries/missinggpgkey.py", line 431, in process
    for gpgkey_url in gpgkeys:
TypeError: 'NoneType' object is not iterable


===========================================================================================================
Actor missing_gpg_keys_inhibitor unexpectedly terminated with exit code: 1 - Please check the above details
===========================================================================================================
2023-02-09 15:51:15.626 INFO     PID: 12037 leapp: Answerfile will be created at /var/log/leapp/answerfile

Debug output written to /var/log/leapp/leapp-preupgrade.log

example of the file:

[root@localhost ~]# cat /etc/leapp/files/leapp_upgrade_repositories.repo 
[APPSTREAM]
name=APPSTREAM
baseurl=http://foo.com/bar
enabled=0
gpgcheck=0

[BASEOS]
name=BASEOS
baseurl=http://foo.com/bar
enabled=0
gpgcheck=0

(you can generate the file using prepare_test_env.sh library: customer_repos_hack)

[Jakuje]

Sorry, I got lost in the None and [] comparisons (which probably means it is weird API regardless how much it is covered with tests and documented.

[pirat89]

/rerun

[github-actions]

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5548873

[github-actions]

Testing Farm request for RHEL-8.6-rhui/5548873 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-rhui/5548873 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-8.7.0-Nightly/5548873 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-8.6.0-Nightly/5548873 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-ZStream/5548873 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-ZStream/5548873 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[pirat89]

after spending a time trying various scenarios, it seems to be working! :-)