Add ppc64le upgrade support for SAP HANA #1042

alexxa · 2023-02-15T21:51:16Z

This PR adds the 8to9 upgrade support for SAP HANA hosts running on ppc64le.

github-actions · 2023-02-15T21:51:30Z

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

review please to notify leapp developers of review request
/packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

/rerun to schedule basic regression tests using this pr build and leapp*master* as artifacts
/rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
/rerun-sst to schedule sst tests using this pr build and leapp*master* as artifacts
/rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

commands/command_utils.py

repos/system_upgrade/common/actors/checksaphana/libraries/checksaphana.py

commands/command_utils.py

fernflower · 2023-02-16T12:12:05Z

repos/system_upgrade/common/actors/checksaphana/libraries/checksaphana.py

+        supported_arch = ','.join(SAP_HANA_7TO8_ARCH)
+    elif target_major_version == '9' and arch not in SAP_HANA_8TO9_ARCH:
+        elink = reporting.ExternalLink(
+            url='https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux_for_sap_solutions/9/html/how_to_in-place_upgrade_sap_environments_from_rhel_8_to_rhel_9/index',  # noqa: E501; pylint: disable=line-too-long


Please remove #noqa: E501 , it is possible to refactor that without silencing the linter.

@fernflower @alexxa tbh, in case of URLs I am ok with the use of noqa, as wrapped URLs are not so fast to open from terminal (I need to copy&paste instead of just click on the link). so i have not strong opinion here. also, it's possible to use the RH URL shortener to create public URL (I can create the shorted URL if wanted). the shortened url could be e.g.: https://red.ht/how-to-in-place-upgrade-sap-environments-from-rhel-8-to-rhel-9

Let's have the shortened url then, thanks!

FYI, there are more long URLs in this repo, and #noqa: E501 silencer next to them. Maybe consider to refactor them too if their presence is not desired.

Oh, good catch. Please also fix the other urls as well, I guess not only @pirat89 can use the RH url shortener, so no need to wait for him =)

fernflower

Please do not silence the linter when it can be avoided.

pirat89

@alexxa Several changes are needed. I have created a possible "fix" in my branch:

https://github.com/pirat89/leapp-repository/tree/ppc64le_hana_support

update: unit tests are updated also in the mentioned branch

repos/system_upgrade/common/actors/checksaphana/libraries/checksaphana.py

repos/system_upgrade/common/actors/checksaphana/tests/test_checksaphana.py

repos/system_upgrade/common/actors/checksaphana/libraries/checksaphana.py

fernflower · 2023-02-17T10:57:47Z

repos/system_upgrade/common/actors/checksaphana/libraries/checksaphana.py

+            )
+        ),
+        reporting.Severity(reporting.Severity.HIGH),
+        reporting.Groups([reporting.Groups.SANITY]),


Nit: L251-252 can actually be squashed into reporting.Groups[reporting.Groups.SANITY, reporting.Groups.INHIBITOR]

fernflower

All my comments resolved, thank you, codewise lgtm.

fernflower · 2023-02-17T11:02:50Z

/rerun

github-actions · 2023-02-17T11:07:53Z

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5536595

github-actions · 2023-02-17T11:29:28Z

Testing Farm request for RHEL-8.6-rhui/5536595 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

github-actions · 2023-02-17T11:36:12Z

Testing Farm request for RHEL-7.9-rhui/5536595 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

fernflower · 2023-02-17T11:42:28Z

@alexxa One last thing - please squash the commits and add description to the first one (Now there is just a title).

github-actions · 2023-02-17T12:59:18Z

Testing Farm request for RHEL-7.9-ZStream/5536595 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

github-actions · 2023-02-17T13:00:22Z

Testing Farm request for RHEL-7.9-ZStream/5536595 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

Please add description to 1 commit and squash commits.

github-actions · 2023-02-17T14:15:57Z

Testing Farm request for RHEL-8.6.0-Nightly/5536595 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

github-actions · 2023-02-17T14:30:46Z

Testing Farm request for RHEL-8.7.0-Nightly/5536595 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

Both RHEL8 and RHEL9 are certified for SAP HANA on Power 9. RHEL7 is certified for Power 8. Thererefore, only 8to9 upgrade is possible on ppc64le. See: OAMG-8442

alexxa · 2023-02-20T07:58:57Z

@fernflower Squashed, and the commit body has been added too.

pirat89

looks good now.

## Packaging - Requires cpio (oamg#979) - Requires python3-gobject-base, NetworkManager-libnm (oamg#969) - Bump leapp-repository-dependencies to 9 (oamg#969, oamg#979) ## Upgrade handling ### Fixes - Add leapp RHUI packages to an allowlist to drop confusing reports (oamg#995) - Check only mounted XFS partitions (oamg#1027) - Detect the kernel-core RPM instead of kernel to prevent an error during post-upgrade phases (oamg#1024) - Disable the amazon-id DNF plugin on AWS during the upgrade stage to omit error messages during the upgrade process caused by missing network connection (oamg#990) - Do not create new *pyc files when running leapp after the DNF upgrade transaction (oamg#1017) - Enable upgrades on s390x when /boot is part of rootfs (oamg#991) - Extend the allow list of RHUI clients by azure-sap-apps to omit confusing report (oamg#974) - Filter out PES events unrelated for the used upgrade path and handle overlapping events (oamg#1008) - Fix scan of ceph volumes on systems without ceph-osd (oamg#1011) - Fix scan of ceph volumes when ceph-osd container is not found (oamg#986) - Fix systemd symlinks that become incorrect during the IPU (oamg#972) - Fix the check of memory (RAM) limits (oamg#984) - Fix the upgrade of IBM Z machines configured with ZFCP (oamg#983) - Ignore external accounts in /etc/passwd (oamg#958) - Inhibit the upgrade when entries in /etc/fstab cause overshadowing during the upgrade (oamg#1009) - Prevent leapp failures caused by re-run of leapp in the upgrade initramfs after previous failure, which causes additional confusing error message hiding original bugs (oamg#996) - Prevent the upgrade with RHSM when a baseos and an appstream target repositories are not discovered (oamg#1001) - RHUI(Azure) handle correctly various SAP images (oamg#1037) - Rework the network configuration handling and parse the configuration data properly (oamg#969) - Set RHSM release for non-ga and non-beta channels (oamg#1033) - Use the "grub" library to find the GRUB device (oamg#989) - [IPU 7 -> 8] Detect corrupted grubenv file (oamg#1012) - [IPU 7 -> 8] Ensure that rsyncd stays enabled if it is enabled prior the upgrade(oamg#1043) - [IPU 7 -> 8] Ensure that satellite metapackages are installed after the upgrade (oamg#994) - [IPU 7 -> 8] Ensure the device_cio_free service stays enabled on s390x after the upgrade (oamg#977) - [IPU 7 -> 8] Fixed checks for RHEL SAP IPU 7.9 -> 8.6 (oamg#978) - [IPU 7 -> 8] Fixed migration of ntp to chrony when the ntp service is masked (oamg#966) - [IPU 7 -> 8] Prevent the traceback during migration of sendmail configuration files when the package is not installed (oamg#1041) - [IPU 7 -> 8] Satellite: reindex all related databases to fix issues due to new locales in RHEL 8 (oamg#1007, oamg#1018) - [IPU 7 -> 8] Use the correct domain name in SSSD reports (oamg#1040) - [IPU 8 -> 9] Added checks for RHEL SAP IPU 8.6 -> 9.0 (oamg#978) - [IPU 8 -> 9] CheckVDO: Ask user for the confirmation only on failures and undetermined devices (oamg#961) - [IPU 8 -> 9] Fix the kernel detection during initramfs creation for new kernel on RHEL 9.2+ (oamg#1048) - [IPU 8 -> 9] Fix the upgrade on Azure using RHUI for SAP Apps images (oamg#975) - [IPU 8 -> 9] Handle correctly firewalld version 0.8 (oamg#963) ### Enhancements - Set new upgrade paths (oamg#988): -- RHEL 7.9 -> 8.8, 8.6 (default: 8.8) -- RHEL 8.6 -> 9.0 -- RHEL 8.8 -> 9.2 - Check that used leapp data are valid and compatible with the installed leapp-repository (oamg#1003) - Detect a proxy configuration in YUM/DNF and adjust an error msg on issues caused by the configuration (oamg#914) - Detect and report systemd symlinks that are broken before the upgrade (oamg#972) - Drop obsoleted upgrade paths (oamg#1047) - Improve remediation instructions for packages in unknown repositories (oamg#1010) - Improve the error message to guide users when discovered more space is needed (oamg#956) - Introduce --nogpgcheck option to skip checking of RPM signatures (oamg#910) - Introduced an option to use an ISO file as a target RHEL version content source (oamg#979) - Introduced possibility to specify what systemd services should be enabled/disabled on the upgraded system (oamg#964) - Map the target repositories also based on the installed content (oamg#967) - Provide common information about systemd services (oamg#959) - Register subscribed systems automatically to Red Hat Insights unless --no-insights-register is used (oamg#1000) - Remove obsoleted GPG keys provided by RH after the upgrade to prevent errors (oamg#1022) - Run upgrade process with checking RPM signatures by default (oamg#910, oamg#993, oamg#1025) - Save breadcrumbs results as RHSM facts (oamg#1002) - Small improvements in various reports (oamg#1038, oamg#1039, oamg#1032) - [IPU 8 -> 9] Detect CIFS also when upgrading from RHEL8 to RHEL9 (PR1035) - [IPU 8 -> 9] Detect RoCE on IBM Z machines and check the configuration is safe for the upgrade (oamg#1030) - [IPU 8 -> 9] Enable upgrades of RHEL 8 for SAP HANA to RHEL 9 on ppc64le (oamg#1042) - [IPU 8 -> 9] Improve the handling of blocklisted certificates (oamg#992) ## Additional changes interesting for devels - Started work on bringing up networking inside the upgrade initramfs - currently available for testing and development purposes when LEAPP_DEVEL_INITRAM_NETWORK is set (oamg#960) - Add leapp debug tools to the upgrade initramfs - dracut upgrade module (oamg#997) - Enable disabling of DNF plugins in the dnfplugin library (oamg#990)

## Packaging - Requires cpio (#979) - Requires python3-gobject-base, NetworkManager-libnm (#969) - Bump leapp-repository-dependencies to 9 (#969, #979) ## Upgrade handling ### Fixes - Add leapp RHUI packages to an allowlist to drop confusing reports (#995) - Check only mounted XFS partitions (#1027) - Detect the kernel-core RPM instead of kernel to prevent an error during post-upgrade phases (#1024) - Disable the amazon-id DNF plugin on AWS during the upgrade stage to omit error messages during the upgrade process caused by missing network connection (#990) - Do not create new *pyc files when running leapp after the DNF upgrade transaction (#1017) - Enable upgrades on s390x when /boot is part of rootfs (#991) - Extend the allow list of RHUI clients by azure-sap-apps to omit confusing report (#974) - Filter out PES events unrelated for the used upgrade path and handle overlapping events (#1008) - Fix scan of ceph volumes on systems without ceph-osd (#1011) - Fix scan of ceph volumes when ceph-osd container is not found (#986) - Fix systemd symlinks that become incorrect during the IPU (#972) - Fix the check of memory (RAM) limits (#984) - Fix the upgrade of IBM Z machines configured with ZFCP (#983) - Ignore external accounts in /etc/passwd (#958) - Inhibit the upgrade when entries in /etc/fstab cause overshadowing during the upgrade (#1009) - Prevent leapp failures caused by re-run of leapp in the upgrade initramfs after previous failure, which causes additional confusing error message hiding original bugs (#996) - Prevent the upgrade with RHSM when a baseos and an appstream target repositories are not discovered (#1001) - RHUI(Azure) handle correctly various SAP images (#1037) - Rework the network configuration handling and parse the configuration data properly (#969) - Set RHSM release for non-ga and non-beta channels (#1033) - Use the "grub" library to find the GRUB device (#989) - [IPU 7 -> 8] Detect corrupted grubenv file (#1012) - [IPU 7 -> 8] Ensure that rsyncd stays enabled if it is enabled prior the upgrade(#1043) - [IPU 7 -> 8] Ensure that satellite metapackages are installed after the upgrade (#994) - [IPU 7 -> 8] Ensure the device_cio_free service stays enabled on s390x after the upgrade (#977) - [IPU 7 -> 8] Fixed checks for RHEL SAP IPU 7.9 -> 8.6 (#978) - [IPU 7 -> 8] Fixed migration of ntp to chrony when the ntp service is masked (#966) - [IPU 7 -> 8] Prevent the traceback during migration of sendmail configuration files when the package is not installed (#1041) - [IPU 7 -> 8] Satellite: reindex all related databases to fix issues due to new locales in RHEL 8 (#1007, #1018) - [IPU 7 -> 8] Use the correct domain name in SSSD reports (#1040) - [IPU 8 -> 9] Added checks for RHEL SAP IPU 8.6 -> 9.0 (#978) - [IPU 8 -> 9] CheckVDO: Ask user for the confirmation only on failures and undetermined devices (#961) - [IPU 8 -> 9] Fix the kernel detection during initramfs creation for new kernel on RHEL 9.2+ (#1048) - [IPU 8 -> 9] Fix the upgrade on Azure using RHUI for SAP Apps images (#975) - [IPU 8 -> 9] Handle correctly firewalld version 0.8 (#963) ### Enhancements - Set new upgrade paths (#988): -- RHEL 7.9 -> 8.8, 8.6 (default: 8.8) -- RHEL 8.6 -> 9.0 -- RHEL 8.8 -> 9.2 - Check that used leapp data are valid and compatible with the installed leapp-repository (#1003) - Detect a proxy configuration in YUM/DNF and adjust an error msg on issues caused by the configuration (#914) - Detect and report systemd symlinks that are broken before the upgrade (#972) - Drop obsoleted upgrade paths (#1047) - Improve remediation instructions for packages in unknown repositories (#1010) - Improve the error message to guide users when discovered more space is needed (#956) - Introduce --nogpgcheck option to skip checking of RPM signatures (#910) - Introduced an option to use an ISO file as a target RHEL version content source (#979) - Introduced possibility to specify what systemd services should be enabled/disabled on the upgraded system (#964) - Map the target repositories also based on the installed content (#967) - Provide common information about systemd services (#959) - Register subscribed systems automatically to Red Hat Insights unless --no-insights-register is used (#1000) - Remove obsoleted GPG keys provided by RH after the upgrade to prevent errors (#1022) - Run upgrade process with checking RPM signatures by default (#910, #993, #1025) - Save breadcrumbs results as RHSM facts (#1002) - Small improvements in various reports (#1038, #1039, #1032) - [IPU 8 -> 9] Detect CIFS also when upgrading from RHEL8 to RHEL9 (PR1035) - [IPU 8 -> 9] Detect RoCE on IBM Z machines and check the configuration is safe for the upgrade (#1030) - [IPU 8 -> 9] Enable upgrades of RHEL 8 for SAP HANA to RHEL 9 on ppc64le (#1042) - [IPU 8 -> 9] Improve the handling of blocklisted certificates (#992) ## Additional changes interesting for devels - Started work on bringing up networking inside the upgrade initramfs - currently available for testing and development purposes when LEAPP_DEVEL_INITRAM_NETWORK is set (#960) - Add leapp debug tools to the upgrade initramfs - dracut upgrade module (#997) - Enable disabling of DNF plugins in the dnfplugin library (#990)

alexxa added this to the 8.8/9.2 milestone Feb 15, 2023

alexxa force-pushed the ppc64le_hana_support branch from 4ad2650 to e1afdcc Compare February 15, 2023 21:59

alexxa marked this pull request as draft February 15, 2023 22:08

alexxa force-pushed the ppc64le_hana_support branch from e1afdcc to 5c0e788 Compare February 15, 2023 22:13

pirat89 reviewed Feb 15, 2023

View reviewed changes

commands/command_utils.py Outdated Show resolved Hide resolved

pirat89 reviewed Feb 15, 2023

View reviewed changes

repos/system_upgrade/common/actors/checksaphana/libraries/checksaphana.py Outdated Show resolved Hide resolved

alexxa force-pushed the ppc64le_hana_support branch 6 times, most recently from 66ae689 to 55c8a26 Compare February 16, 2023 10:10

alexxa marked this pull request as ready for review February 16, 2023 10:20

alexxa requested a review from pirat89 February 16, 2023 10:20

fernflower reviewed Feb 16, 2023

View reviewed changes

commands/command_utils.py Outdated Show resolved Hide resolved

fernflower reviewed Feb 16, 2023

View reviewed changes

fernflower requested changes Feb 16, 2023

View reviewed changes

pirat89 requested changes Feb 16, 2023

View reviewed changes

alexxa force-pushed the ppc64le_hana_support branch 2 times, most recently from 16f6f8c to c8a2202 Compare February 17, 2023 09:52

alexxa requested review from pirat89 and fernflower February 17, 2023 10:51

fernflower reviewed Feb 17, 2023

View reviewed changes

fernflower previously approved these changes Feb 17, 2023

View reviewed changes

pirat89 previously approved these changes Feb 17, 2023

View reviewed changes

Add ppc64le upgrade support for SAP HANA

29b3405

Both RHEL8 and RHEL9 are certified for SAP HANA on Power 9. RHEL7 is certified for Power 8. Thererefore, only 8to9 upgrade is possible on ppc64le. See: OAMG-8442

alexxa dismissed pirat89’s stale review via 29b3405 February 20, 2023 07:49

alexxa force-pushed the ppc64le_hana_support branch from c8a2202 to 29b3405 Compare February 20, 2023 07:49

pirat89 approved these changes Feb 20, 2023

View reviewed changes

pirat89 merged commit 77decf6 into oamg:master Feb 20, 2023

pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Feb 20, 2023

pirat89 mentioned this pull request Feb 21, 2023

# Release 0.18.0 #1049

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ppc64le upgrade support for SAP HANA #1042

Add ppc64le upgrade support for SAP HANA #1042

alexxa commented Feb 15, 2023

github-actions bot commented Feb 15, 2023

fernflower Feb 16, 2023

pirat89 Feb 17, 2023 •

edited

fernflower Feb 17, 2023

alexxa Feb 17, 2023

fernflower Feb 17, 2023 •

edited

fernflower left a comment

pirat89 left a comment •

edited

fernflower Feb 17, 2023 •

edited

fernflower left a comment

fernflower commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

fernflower commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

alexxa commented Feb 20, 2023

pirat89 left a comment

Add ppc64le upgrade support for SAP HANA #1042

Add ppc64le upgrade support for SAP HANA #1042

Conversation

alexxa commented Feb 15, 2023

github-actions bot commented Feb 15, 2023

Thank you for contributing to the Leapp project!

fernflower Feb 16, 2023

Choose a reason for hiding this comment

pirat89 Feb 17, 2023 • edited

Choose a reason for hiding this comment

fernflower Feb 17, 2023

Choose a reason for hiding this comment

alexxa Feb 17, 2023

Choose a reason for hiding this comment

fernflower Feb 17, 2023 • edited

Choose a reason for hiding this comment

fernflower left a comment

Choose a reason for hiding this comment

pirat89 left a comment • edited

Choose a reason for hiding this comment

fernflower Feb 17, 2023 • edited

Choose a reason for hiding this comment

fernflower left a comment

Choose a reason for hiding this comment

fernflower commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

fernflower commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

alexxa commented Feb 20, 2023

pirat89 left a comment

Choose a reason for hiding this comment

pirat89 Feb 17, 2023 •

edited

fernflower Feb 17, 2023 •

edited

pirat89 left a comment •

edited

fernflower Feb 17, 2023 •

edited