Enable building for EL 9 and support Python 3.12 #855

pirat89 · 2024-04-02T12:51:33Z

This patch enables building on EL9 along with the testing infrastructure and dev environment prepared for EL9 and EL10.

Included changes:

Enable EL9 builds in packit
Add build container for EL9
Add test container for EL10
Add tests on Python 3.12 on ubi10 (really it's ubi9) unit test GH action
Update Makefile to include the new containers
Handle deprecations in Python 3.12

github-actions · 2024-04-02T12:51:44Z

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

review please @oamg/developers to notify leapp developers of the review request
/packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

/rerun to schedule basic regression tests using this pr build and leapp-repository*master* as artifacts
/rerun 42 to schedule basic regression tests using this pr build and leapp-repository*PR42* as artifacts
/rerun-sst to schedule sst tests using this pr build and leapp-repository*master* as artifacts
/rerun-sst 42 to schedule sst tests using this pr build and leapp-repository*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

fernflower · 2024-04-02T13:26:57Z

/packit-build

fernflower · 2024-04-02T13:31:01Z

/packit copr-build

fernflower · 2024-04-02T16:38:36Z

@pirat89 You are missing packit refactor, please rebase against recent master

pirat89 · 2024-04-02T20:11:07Z

@fernflower ~~I guess that PEBKAC. I rebased, but I have a feel throw out all changes from master. I will take a look tomorrow. Thanks for the checking.~~ It's pebkac - I just looked at leapp-repository instead :D thanks!

fernflower · 2024-04-03T08:11:08Z

/packit copr-build

leapp/repository/__init__.py

res/container-builds/Containerfile.ubi9

res/container-tests/Containerfile.ubi10

matejmatuska · 2024-06-28T11:48:13Z

/packit copr-build

leapp/messaging/answerstore.py

matejmatuska · 2024-07-12T12:01:56Z

/rerun

This is initial commit delivering some ground work needed for leapp to be able to work with Python3.12 on EL 9 systems and prepare testing. Most of the work has been delivered by Matej Matuska (thanks!!) Summary of changes: * Add el9 build container * Add fake RHEL 10 container for local containerized tests As RHEL 10 UBI isn't available yet, use RHEL 9 UBI with Python 3.12 virtualenv. The container manually updates the pytest and six modules after installing requirements as the currently used pytest version is too old for Python 3.12. setup() functions defined at module level are unsupported in the newer pytest versions, these are replaced by autouse=True fixtures. * Makefile: include new EL and Fedora containers for tests and builds * Packit: build automatically for epel-9-x86_64 Co-authored-by: Matej Matuska <mmatuska@redhat.com>

The find_module function has been deprecated for a long time and it has been removed in Python3.12. To keep the backward compatibility, we introduce compat.load_module() function that is compatible with Python2.7 -> Python3.12 now. Replacing all previous load of module in code by this function. Similar applies for the pkgutil.get_loader() Co-authored-by: Matej Matuska <mmatuska@redhat.com>

AttributeError: module 'configparser' has no attribute 'SafeConfigParser'

Currently the fake RHEL 10 container is used (based on ubi9).

pirat89 · 2024-07-17T15:16:31Z

All changes seems good to me and last two unfinished tests are possibly broken - I haven't been able to pass them in last 20+ hours. Seems that all required changes have been delivered.

## Packaging - Start building for EL 9 in the upstream repository on COPR (oamg#855) ## Framework ### Enhancements - Minor update in the summary overview to highlight what is present in the pre-upgrade report (oamg#858) - Store metadata about actors, workflows, and dialogs inside leapp audit db (oamg#847, oamg#867) ## Leapp (tool) ### Enhancements - Implement singleton leapp execution to prevent multiple running leapp instances on the system in the same time (oamg#851) ## stdlib ### Fixes - Close properly all file descriptors when executing shell commands via `run` (oamg#880) ## Modifications - Code is now Python3.12 compatible (oamg#855)

## Packaging - Start building for EL 9 in the upstream repository on COPR (#855) ## Framework ### Enhancements - Minor update in the summary overview to highlight what is present in the pre-upgrade report (#858) - Store metadata about actors, workflows, and dialogs inside leapp audit db (#847, #867) ## Leapp (tool) ### Enhancements - Implement singleton leapp execution to prevent multiple running leapp instances on the system in the same time (#851) ## stdlib ### Fixes - Close properly all file descriptors when executing shell commands via `run` (#880) ## Modifications - Code is now Python3.12 compatible (#855)

pirat89 force-pushed the poc-ipu-9-10 branch from e4f6f88 to a47fca6 Compare April 2, 2024 12:55

pirat89 force-pushed the poc-ipu-9-10 branch from a47fca6 to 7f772d6 Compare April 2, 2024 20:13

Rezney reviewed Apr 7, 2024

View reviewed changes

leapp/repository/__init__.py Outdated Show resolved Hide resolved