snactor: Fix load_module missing in Python 3.12 #869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0x0d
reviewed
Jun 28, 2024
Comment on lines
+34
to
+36
| spec = importer.find_spec(name) | ||
| mod = importlib.util.module_from_spec(spec) |
There was a problem hiding this comment.
Not sure how that would work, but since both find_spec and module_from_spec were added in python 3.4 and python 3.5, should we covert both of them inside a condition to only load if that's the specific version? If that code runs on python2.7, that will probably fail. If snactor doesn't run on python 2.7 at all, it might be fine 🤔
There was a problem hiding this comment.
Yes I will add the condition, this is still work in progress.
matejmatuska
force-pushed
the
fix-snactor-load_module
branch
from
eae9c9a
to
03c651c
Compare
matejmatuska
force-pushed
the
fix-snactor-load_module
branch
from
933f39f
to
63ec949
Compare
|
Closing, this will be covered in #855 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution is taken from #855.