Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out strings with newlines properly #757

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Comment out strings with newlines properly #757

merged 2 commits into from
Feb 14, 2022

Conversation

fernflower
Copy link
Member

Introduce a _comment_out helper function to be used
in answerfile generation. Tests included.

Also unify ini file loading in answerstore and refactor
into a class method.

Related: OAMG-5861

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
If you want to re-run tests or request review, you can use following commands as a comment:

  • leapp-ci build to run copr build and e2e tests in OAMG CI
  • review please to notify leapp developers of review request
  • /packit copr-build to submit a public copr build using packit

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

@centos-ci
Copy link

Can one of the admins verify this patch?

@fernflower
Copy link
Member Author

/rerun

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3361925

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Testing Farm request for 7to8/3304543,3361925 regression testing has been created. Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Testing Farm request for 8to9/3304543,3361925 regression testing has been created. Once finished, results should be available here.
Full pipeline log.

@fernflower fernflower force-pushed the genproperanswerfile branch 3 times, most recently from 4b5aceb to fa181d9 Compare February 8, 2022 10:00
@fernflower fernflower changed the title [WIP] Comment out strings with newlines properly Comment out strings with newlines properly Feb 8, 2022
@fernflower
Copy link
Member Author

/rerun

vinzenz
vinzenz previously approved these changes Feb 8, 2022
View reviewed changes
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3384086

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Testing Farm request for 7to8/3304543,3384086 regression testing has been created. Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Testing Farm request for 8to9/3304543,3384086 regression testing has been created. Once finished, results should be available here.
Full pipeline log.

pirat89
pirat89 reviewed Feb 8, 2022
View reviewed changes
leapp/dialogs/components.py Outdated Show resolved Hide resolved
@fernflower
Copy link
Member Author

/rerun

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3386987

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Testing Farm request for 7to8/3304543,3386987 regression testing has been created. Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Testing Farm request for 8to9/3304543,3386987 regression testing has been created. Once finished, results should be available here.
Full pipeline log.

@fernflower
Comment out strings with newlines properly
b8d3eed 
Introduce a _comment_out helper function to be used
in answerfile generation. Tests included.

Also unify ini file loading in answerstore and refactor
into a class method.

Related: OAMG-5861
@fernflower
Prevent newlines in dialog title and label
e943318 
As another precaution dialogs won't have a title and
any components' label with newlines as well.
@fernflower
Copy link
Member Author

/rerun

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3388397

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Testing Farm request for 7to8/3304543,3388397 regression testing has been created. Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Testing Farm request for 8to9/3304543,3388397 regression testing has been created. Once finished, results should be available here.
Full pipeline log.

pirat89
pirat89 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@pirat89 pirat89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question regarding the title, but it's good otherwise :)

@Rezney Rezney merged commit 94d5f7a into oamg:master Feb 14, 2022
@Rezney Rezney mentioned this pull request Mar 12, 2022
Merged
pirat89 added a commit to pirat89/leapp that referenced this pull request Mar 17, 2022
@pirat89
# Release 0.14.0
ce78794 
## Packaging

- Add depency on `python3` for el8+ (`python3` refers to the distribution python)
- Bump `leapp-framework` to 2.2
- Bump `leapp-framework-dependencies` to 6
- Doc: --report-schema in manpage (oamg#686)

## Framework
### Fixes

- Fix issues with initialisation of loggers (oamg#764)
- Fix TypeError during JSON serialization in dialogs on Python3 (oamg#760)
- Prevent breaking the answerfile when dialog fields contain newlines (oamg#757)
- Check answerfile upon loading (oamg#759)
- Fix the multiprocessing on Python 3.9 on Mac OS

### Enhancements

- Dialogs: print the reason field for question in the answerfile (oamg#762)
- Added possibility to specify the report format version (oamg#686)

## stdlib

### Enhancements
- Introduced `stdlib.path` library `get_common_*_path` functions for the scanning repositories, actors, etc. paths outside of the actor execution (oamg#742)
pirat89 pushed a commit to Rezney/leapp that referenced this pull request Mar 18, 2022
@Rezney @pirat89
Release 0.14.0
92feec5 
## Packaging

- Add depency on `python3` for el8+ (`python3` refers to the distribution python)
- Bump `leapp-framework` to 2.2
- Bump `leapp-framework-dependencies` to 6
- Doc: --report-schema in manpage (oamg#686)

## Framework
### Fixes

- Fix issues with initialisation of loggers (oamg#764)
- Fix TypeError during JSON serialization in dialogs on Python3 (oamg#760)
- Prevent breaking the answerfile when dialog fields contain newlines (oamg#757)
- Check answerfile upon loading (oamg#759)
- Fix the multiprocessing on Python 3.9 on Mac OS

### Enhancements

- Dialogs: print the reason field for question in the answerfile (oamg#762)
- Added possibility to specify the report format version (oamg#686)

## stdlib

### Enhancements
- Introduced `stdlib.path` library `get_common_*_path` functions for the scanning repositories, actors, etc. paths outside of the actor execution (oamg#742)
Rezney added a commit to Rezney/leapp that referenced this pull request Mar 18, 2022
@Rezney
Release 0.14.0
2d96d91 
## Packaging

- Add depency on `python3` for el8+ (`python3` refers to the distribution python)
- Bump `leapp-framework` to 2.2
- Bump `leapp-framework-dependencies` to 6
- Doc: --report-schema in manpage (oamg#686)

## Framework
### Fixes

- Fix issues with initialisation of loggers (oamg#764)
- Fix TypeError during JSON serialization in dialogs on Python3 (oamg#760)
- Prevent breaking the answerfile when dialog fields contain newlines (oamg#757)
- Check answerfile upon loading (oamg#759)
- Fix the multiprocessing on Python 3.9 on Mac OS

### Enhancements

- Dialogs: print the reason field for question in the answerfile (oamg#762)
- Added possibility to specify the report format version (oamg#686)

## stdlib

### Enhancements
- Introduced `stdlib.path` library `get_common_*_path` functions for the scanning repositories, actors, etc. paths outside of the actor execution (oamg#742)
pirat89 pushed a commit that referenced this pull request Mar 18, 2022
@Rezney @pirat89
Release 0.14.0
d3c38f5 
## Packaging

- Add depency on `python3` for el8+ (`python3` refers to the distribution python)
- Bump `leapp-framework` to 2.2
- Bump `leapp-framework-dependencies` to 6
- Doc: --report-schema in manpage (#686)

## Framework
### Fixes

- Fix issues with initialisation of loggers (#764)
- Fix TypeError during JSON serialization in dialogs on Python3 (#760)
- Prevent breaking the answerfile when dialog fields contain newlines (#757)
- Check answerfile upon loading (#759)
- Fix the multiprocessing on Python 3.9 on Mac OS

### Enhancements

- Dialogs: print the reason field for question in the answerfile (#762)
- Added possibility to specify the report format version (#686)

## stdlib

### Enhancements
- Introduced `stdlib.path` library `get_common_*_path` functions for the scanning repositories, actors, etc. paths outside of the actor execution (#742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirat89 pirat89 pirat89 approved these changes

@vinzenz vinzenz Awaiting requested review from vinzenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fernflower @centos-ci @vinzenz @pirat89 @Rezney