Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add embark-kill-ring-map and embark-kill-ring-remove #413

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Add embark-kill-ring-map and embark-kill-ring-remove #413

merged 3 commits into from
Nov 19, 2021

Conversation

minad
Copy link
Contributor

@minad minad commented Nov 19, 2021

@minad
Copy link
Contributor Author

minad commented Nov 19, 2021

This feature is mentioned in the wish list, so I thought I should add this, since we also added the other remove from recentf/history commands.

@minad
Introduce embark--read-from-history
aa9f0d7 
One could argue that the remove from history commands should rather live in
Consult, since they are based on completion. However it seems that these
commands are only useful as minibuffer actions. If I recall correctly we came to
this conclusion before when we added `embark-recentf-remove`.
@minad
Fix warnings
552dc4f
@oantolin
Copy link
Owner

I agree that these commands would only realistically be run as minibuffer actions. Let's have them here.

@oantolin oantolin merged commit fb09ff8 into oantolin:master Nov 19, 2021
@oantolin
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minad @oantolin