Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phoenix] Python version of phoenix (enhanced) #41

Merged
merged 4 commits into from
Dec 19, 2023
Merged

[Phoenix] Python version of phoenix (enhanced) #41

merged 4 commits into from
Dec 19, 2023

Conversation

bzizou
Copy link
Contributor

@bzizou bzizou commented Dec 13, 2023

Phoenix converted into python, with enhancements: better logging and variables are now integrated into the oar.conf file.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 125 lines in your changes are missing coverage. Please review.

Comparison is base (59e209e) 77.24% compared to head (3887d1c) 76.24%.
Report is 7 commits behind head on master.

❗ Current head 3887d1c differs from pull request most recent head 05ed113. Consider uploading reports for the commit 05ed113 to get more accurate results

Files Patch % Lines
oar/tools/oar_phoenix.py 0.00% 125 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   77.24%   76.24%   -1.00%     
==========================================
  Files          79       80       +1     
  Lines        9544     9669     +125     
  Branches     1890     1914      +24     
==========================================
  Hits         7372     7372              
- Misses       1562     1687     +125     
  Partials      610      610              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adfaure
Copy link
Contributor

adfaure commented Dec 13, 2023

Thank you.

It can be merged.

If you still want to improve the code there are few possible changes:

  • Rename the db associated with phoenix as state (or else) to make the code less confusing with the oar db.
  • As it is a brand new python file we might add some typing.
  • Use a the python logger instead of doing it manually.

@bzizou bzizou self-assigned this Dec 13, 2023
@bzizou bzizou merged commit 17c3d35 into master Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants