Fixing broken control-map link in the docs #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,7 +53,7 @@ box_data = np.array( | |||
|
|
|||
| Let's create a simple visualization pipeline. | |||
| For an explanation of what control-map is doing please check our tutorial at: | |||
| [paz/examples/tutorials/controlmap_processor.py](paz/examples/tutorials/controlmap_processor.py) | |||
| [paz/examples/tutorials/controlmap_processor.py](https://github.com/oarriaga/paz/blob/master/examples/tutorials/controlmap_processor.py) | |||
There was a problem hiding this comment.
Thank you for the PR! Could you please make it a hyperlink? Similar to how it's done on line 5
There was a problem hiding this comment.
Hi @proneetsharma !
Sorry, but I don't understand your request. Could you please explain it? I think I did what you're asking. I created an absolute hyperlink like on line 5.
There was a problem hiding this comment.
I mean instead of file path you can make with a text, something like this:
For an explanation of what control-map is doing please check our tutorial here.
There was a problem hiding this comment.
Looks good. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #158 mentions that the link is broken. This change fixes the issue.