Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python #587

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Upgrade python #587

merged 4 commits into from
Mar 18, 2024

Conversation

rpiazza
Copy link
Contributor

@rpiazza rpiazza commented Mar 16, 2024

@clenk

Can you look into this? For some reason the pre-commit is not working. Nothing stands out - see the actions

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.43%. Comparing base (17445a0) to head (4f0e1d2).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage   87.29%   87.43%   +0.13%     
==========================================
  Files         153      155       +2     
  Lines       18033    18088      +55     
==========================================
+ Hits        15742    15815      +73     
+ Misses       2291     2273      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clenk
Copy link
Contributor

clenk commented Mar 18, 2024

Think it might be caused by PyCQA/isort#2077 so we should upgrade the version of isort used in https://github.com/oasis-open/cti-python-stix2/blob/master/.pre-commit-config.yaml#L19.

@rpiazza
Copy link
Contributor Author

rpiazza commented Mar 18, 2024

I guess I need to do it because of permissions, right?

@rpiazza rpiazza merged commit 74873aa into master Mar 18, 2024
11 checks passed
@rpiazza rpiazza deleted the upgrade-python branch March 18, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants