Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional schemas #47

Merged
merged 4 commits into from
May 2, 2018
Merged

Additional schemas #47

merged 4 commits into from
May 2, 2018

Conversation

clenk
Copy link
Contributor

@clenk clenk commented Apr 27, 2018

Fixes #43. Note that to use a schema for a custom observable object type or custom observable extension, you have to have a schema for observed-data, but it can be an empty object.

@clenk clenk added this to the 1.0 milestone Apr 27, 2018
@codecov-io
Copy link

codecov-io commented Apr 27, 2018

Codecov Report

Merging #47 into master will increase coverage by 0.43%.
The diff coverage is 98.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage    88.2%   88.64%   +0.43%     
==========================================
  Files          29       29              
  Lines        2577     2597      +20     
==========================================
+ Hits         2273     2302      +29     
+ Misses        304      295       -9
Impacted Files Coverage Δ
stix2validator/util.py 75.51% <ø> (-1.42%) ⬇️
stix2validator/scripts/stix2_validator.py 0% <ø> (ø) ⬆️
stix2validator/test/indicator_tests.py 100% <100%> (ø) ⬆️
stix2validator/test/observed_data_tests.py 100% <100%> (ø) ⬆️
stix2validator/validator.py 65.77% <100%> (+2.99%) ⬆️
stix2validator/test/__init__.py 95% <83.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27f27d...c00190c. Read the comment docs.

@clenk clenk requested a review from gtback May 1, 2018 12:41
Copy link
Contributor

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtback gtback merged commit 0220f03 into master May 2, 2018
@gtback gtback deleted the additional-schemas branch May 2, 2018 15:14
@gtback gtback modified the milestone: 1.0 Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants