Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate suppression status from kind #371

Closed
ghost opened this issue Apr 13, 2019 · 0 comments
Closed

Separate suppression status from kind #371

ghost opened this issue Apr 13, 2019 · 0 comments
Labels

Comments

@ghost
Copy link

ghost commented Apr 13, 2019

BACKGROUND

We currently have four values for suppression.kind: "suppressedInSource", "suppressedExternally", "underReview", and "suppressionRejected". You see that these really fall into two categories: "suppressedInSource" and "suppressedExternally" says how the result was suppressed, and underReview and suppressionRejected track the process of deciding whether the result should be suppressed.

Not only are these different in semantics, but they are different in "number": a result might be suppressed in multiple ways, but it is in only one status at a time.

NOTE: We had a similar situation with result.level, which original included both "severity" values like warning and error, and "status" values like open. So we split result.level into two properties, level and kind.

While we're at it, we tighten up the value names.

SCHEMA CHANGES

In the suppression object:

  • In the kind property, restrict the valid values to "inSource" and "external".
  • Add a property status of type string, optional, with valid values "accepted", "underReview" and "rejected", default: "accepted".
@ghost ghost self-assigned this Apr 13, 2019
ghost pushed a commit that referenced this issue Apr 14, 2019
@ghost ghost added merged Changes merged into provisional draft. resolved-fixed labels Apr 14, 2019
@ghost ghost closed this as completed Apr 14, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

0 participants