feat(cmd): Add -y for answer yes to all questions #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matevz
force-pushed
the
matevz/yes-to-all
branch
from
0e857cc
to
6519f57
Compare
kostko
reviewed
Mar 20, 2023
| @@ -41,7 +41,7 @@ func LoadAccount(cfg *config.Config, name string) wallet.Account { | |||
| cobra.CheckErr(err) | |||
|
|
|||
| var passphrase string | |||
| if af.RequiresPassphrase() { | |||
| if af.RequiresPassphrase() && !txYes { | |||
There was a problem hiding this comment.
How will this work if txYes is true? Passphrase will always be empty?
There was a problem hiding this comment.
Yeah, it will just pass empty string for password, so you can't unlock password-encrypted accounts in non-interactive mode currently.
kostko
approved these changes
Mar 20, 2023
matevz
force-pushed
the
matevz/yes-to-all
branch
from
6519f57
to
5611e39
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #13