ci: undisable cgo on release build #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without cgo, we can't use ledger. the library does not link to libusb and always answers that no devices are connected. https://github.com/Zondax/hid/blob/v0.9.1/hid_disabled.go#L7 this CLI is intended to work with ledger, so we're enabling this.
kostko
approved these changes
Apr 12, 2023
| @@ -6,8 +6,6 @@ before: | |||
|
|
|||
| builds: | |||
| - binary: oasis | |||
| env: | |||
| - CGO_ENABLED=0 | |||
There was a problem hiding this comment.
I believe the only reason for having this was that this config was copied from the oasis-web3-gateway that had this set.
There was a problem hiding this comment.
as long as folks aren't using this in a no-libc container or something :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit message
we're not aware of anything that specifically needed a non-cgo build. but if anyone depended on the program not being with cgo, you're welcome to comment.