runtime: Add OASIS_UNSAFE_USE_LOCALNET_CHAINID env flag #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2023
gw0
reviewed
Jan 13, 2023
| binaries: emerald-paratime | ||
| clean: no | ||
| setup: | | ||
| export OASIS_UNSAFE_USE_LOCALNET_CHAINID=1 |
There was a problem hiding this comment.
From the variable name I would expect the following usage OASIS_UNSAFE_USE_LOCALNET_CHAINID=0xa514. But then this could also be reused for building official Testnet and Mainnet variants...
There was a problem hiding this comment.
There are bunch of issues around this:
CHAIN_IDis constant and can only be set at compile time.- And now since it needs to be hardcoded at compile time, up to date rust has issues with parsing env variables to integers.
- We could probably use konst (see the last comment), but it smells wrong.
So I dropped the idea of custom chain IDs read from env and just introduced a simple flag.
nhynes
approved these changes
Jan 13, 2023
matevz
force-pushed
the
matevz/feature/localnet_chainid
branch
from
90d9005
to
fb8d090
Compare
kostko
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction of another localnet chain ID
0xa514ifOASIS_UNSAFE_USE_LOCALNET_CHAINenv variable is set targeted at dApp devs for testing on the local stack. Since the chain ID is hardcoded into runtime binary, this PR also adds the localnet release beside the existing one to CI.Related: oasisprotocol/oasis-web3-gateway#348