Nodes section placeholder #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buberdds
force-pushed
the
mz/computeNodes
branch
from
8065b3a
to
f420827
Compare
lukaw3d
approved these changes
Feb 8, 2023
lukaw3d
reviewed
Feb 8, 2023
| > | ||
| <Typography component="span" sx={{ fontSize: '48px', fontWeight: 700, color: COLORS.brandDark }}> | ||
| {/* TODO: Replace with real value when endpoint is ready */} | ||
| {t('computeNodes.value', { value: 2000 })} |
There was a problem hiding this comment.
https://www.oasisscan.com/paratimes/000000000000000000000000000000000000000000000000e2eaa99fc008f87f/nodeList says current number is: 70 active nodes, 1 inactive
There was a problem hiding this comment.
I will validate what number we want to show when API is ready. Is it a number of all or just active nodes.
There was a problem hiding this comment.
We end up with a new mockup for this section, PR updated.
buberdds
force-pushed
the
mz/computeNodes
branch
from
f420827
to
775cb69
Compare
buberdds
force-pushed
the
mz/computeNodes
branch
2 times, most recently
from
0d8721b
to
70b0046
Compare
buberdds
force-pushed
the
mz/computeNodes
branch
from
70b0046
to
1189864
Compare
buberdds
force-pushed
the
mz/computeNodes
branch
from
1189864
to
511bca0
Compare
lukaw3d
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
badgeprop instead ofpercentage