Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer using the ETH address for accounts #244

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Prefer using the ETH address for accounts #244

merged 4 commits into from
Mar 29, 2023

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Mar 27, 2023

Whenever it's available.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 27, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fecfd0d
Status:⚡️  Build in progress...

View logs

@csillag csillag force-pushed the csillag/show-account-eth-address branch 2 times, most recently from 1160ea0 to 37c58cb Compare March 27, 2023 14:59
lukaw3d
lukaw3d reviewed Mar 27, 2023
View reviewed changes
src/app/utils/helpers.ts Outdated Show resolved Hide resolved
src/app/utils/helpers.ts Outdated Show resolved Hide resolved
src/app/utils/helpers.ts Outdated Show resolved Hide resolved
src/app/utils/helpers.ts Outdated Show resolved Hide resolved
@csillag csillag force-pushed the csillag/show-account-eth-address branch 2 times, most recently from 0e98a47 to 1dac10b Compare March 27, 2023 22:43
lukaw3d
lukaw3d reviewed Mar 28, 2023
View reviewed changes
src/app/utils/helpers.ts Outdated Show resolved Hide resolved
@csillag csillag force-pushed the csillag/show-account-eth-address branch 4 times, most recently from af83d05 to b2b4a68 Compare March 28, 2023 02:06
@csillag
Copy link
Contributor Author

csillag commented Mar 28, 2023

The toChecksumAddress() function (imported from ethereumjs) is causing some issues, but only when used in the tests... :(

@csillag csillag force-pushed the csillag/show-account-eth-address branch from 1b5ae67 to 135b0b2 Compare March 28, 2023 13:15
@csillag csillag force-pushed the csillag/show-account-eth-address branch from 326427d to fecfd0d Compare March 29, 2023 07:52
@csillag csillag merged commit 8d7f777 into master Mar 29, 2023
@csillag csillag deleted the csillag/show-account-eth-address branch March 29, 2023 07:55
@csillag csillag mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaw3d lukaw3d lukaw3d approved these changes

@lubej lubej Awaiting requested review from lubej lubej is a code owner

@buberdds buberdds Awaiting requested review from buberdds buberdds is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csillag @lukaw3d