Include count clipped prop in pagination #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
02b428e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e9e26c9e.oasis-explorer.pages.dev |
| Branch Preview URL: | https://mz-paginationclippedcount.oasis-explorer.pages.dev |
buberdds
force-pushed
the
mz/paginationClippedCount
branch
2 times, most recently
from
2981bb8
to
c4e8530
Compare
lukaw3d
approved these changes
Mar 29, 2023
| }} | ||
| component={Link} | ||
| to={item.page == null ? '' : linkToPage(item.page)} | ||
| {...item} | ||
| sx={isTotalCountClipped && item.type === 'last' ? { pointerEvents: 'none', cursor: 'default' } : {}} |
buberdds
force-pushed
the
mz/paginationClippedCount
branch
from
c4e8530
to
b4358c1
Compare
buberdds
force-pushed
the
mz/paginationClippedCount
branch
from
b4358c1
to
02b428e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion we want replace "Last" with "..." if clipped.
> 100 pageshttps://859ba30c.oasis-explorer.pages.dev/emerald/transactions
https://859ba30c.oasis-explorer.pages.dev/emerald/blocks
last page of
> 100 pageshttps://859ba30c.oasis-explorer.pages.dev/emerald/account/oasis1qzypxmt5xg8039329zvre7hxe7kn0vxfugsknqtw?page=5699
< 100 pageshttps://859ba30c.oasis-explorer.pages.dev/emerald/blocks/1201390
https://859ba30c.oasis-explorer.pages.dev/emerald/account/0xE004dA9962A02c2F5EA66B2AA88360B49617ee56
we want to render pagination even for
<= 10 itemshttps://859ba30c.oasis-explorer.pages.dev/emerald/blocks/5093464