Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup gitlint #313

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Setup gitlint #313

merged 1 commit into from
Apr 24, 2023

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Apr 20, 2023

PR follows gitlint usage in other repos. Not sure if it's the best way to handle python tasks (we will have more soon).

original makefile output sample action logs

*** Running gitlint for commits from origin/master (6d67e3a)... 
3: B1 Line exceeds max length (86>80)
make: *** [Makefile:77: lint-git] Error 1
Error: Process completed with exit code 2.

yarn gitlint sample action logs

Run yarn gitlint 
yarn run v1.22.19
$ node ./internals/scripts/gitlint.js
*** Running gitlint for commits from origin/master (ce0c8761d90419377e35b2e55a6fdd1701c499dc)
Commit b6ed02c76e:
1: CC2 Fixup commits are not allowed

Commit b33af2d565:
1: T1 Title exceeds max length (82>72)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

Need to update other repos configs to use contrib=contrib-disallow-cleanup-commits rule instead of a custom one.

@buberdds buberdds requested review from lukaw3d and tjanez April 20, 2023 13:39
internals/scripts/gitlint.js Show resolved Hide resolved
package.json Show resolved Hide resolved
.github/workflows/ci-lint.yml Show resolved Hide resolved
.github/workflows/ci-lint.yml Show resolved Hide resolved
package.json Show resolved Hide resolved
.gitlint Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Apr 24, 2023

Deployed to Cloudflare Pages

Latest commit:
Status:✅ Deploy successful!
Preview URL: https://a07ca1dd.oasis-explorer.pages.dev

@buberdds buberdds merged commit 438958d into master Apr 24, 2023
@buberdds buberdds deleted the mz/gitlint branch April 24, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants